Firmware/opensbi
8
0
Fork 0
forked from Mirrors/opensbi
Code Pull Requests Activity

lib: sbi: Fix is_region_valid()

Browse Source 
When order is equal to __riscv_xlen, the shift operation will not perform
any operation, which will cause reg->base & (BIT(reg->order) - 1) to always
be 0, and the condition has not been established.

This patch fixes this bug.

Signed-off-by: Xiang W <wxjstz@126.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
This commit is contained in:
Xiang W
2022-11-24 11:16:05 +08:00
committed by Anup Patel
parent 74e20293c4
commit fc82e84329
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/sbi/sbi_domain.c
View File

@@ -146,6 +146,9 @@ static bool is_region_valid(const struct sbi_domain_memregion *reg)
if (reg->order < 3 || __riscv_xlen < reg->order)
return FALSE;
if (reg->order == __riscv_xlen && reg->base != 0)
return FALSE;
if (reg->base & (BIT(reg->order) - 1))
return FALSE;