Firmware/opensbi
8
0
Fork 0
forked from Mirrors/opensbi
Code Pull Requests Activity

lib: sbi: Remove redundant hartid parameter from sbi_hart_init()

Browse Source 
The hartid parameter of sbi_hart_init() is not used anywhere in
sbi_hart_init() implementation so let's remove it.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
Reviewed-by: Atish Patra <atish.patra@wdc.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
This commit is contained in:
Anup Patel
2020-09-20 13:49:02 +05:30
committed by Anup Patel
parent a126886bfa
commit f81d6f6f43
3 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/sbi/sbi_hart.h
View File

@@ -27,7 +27,7 @@ enum sbi_hart_features {
struct sbi_scratch;
int sbi_hart_init(struct sbi_scratch *scratch, u32 hartid, bool cold_boot);
int sbi_hart_init(struct sbi_scratch *scratch, bool cold_boot);
extern void (*sbi_hart_expected_trap)(void);
static inline ulong sbi_hart_expected_trap_addr(void)

14
lib/sbi/sbi_hart.c
View File

@@ -33,7 +33,7 @@ struct hart_features {
};
static unsigned long hart_features_offset;
static void mstatus_init(struct sbi_scratch *scratch, u32 hartid)
static void mstatus_init(struct sbi_scratch *scratch)
{
unsigned long mstatus_val = 0;
@@ -62,7 +62,7 @@ static void mstatus_init(struct sbi_scratch *scratch, u32 hartid)
csr_write(CSR_SATP, 0);
}
static int fp_init(u32 hartid)
static int fp_init(struct sbi_scratch *scratch)
{
#ifdef __riscv_flen
int i;
@@ -83,7 +83,7 @@ static int fp_init(u32 hartid)
return 0;
}
static int delegate_traps(struct sbi_scratch *scratch, u32 hartid)
static int delegate_traps(struct sbi_scratch *scratch)
{
const struct sbi_platform *plat = sbi_platform_ptr(scratch);
unsigned long interrupts, exceptions;
@@ -435,7 +435,7 @@ __mhpm_skip:
hfeatures->features |= SBI_HART_HAS_TIME;
}
int sbi_hart_init(struct sbi_scratch *scratch, u32 hartid, bool cold_boot)
int sbi_hart_init(struct sbi_scratch *scratch, bool cold_boot)
{
int rc;
@@ -452,13 +452,13 @@ int sbi_hart_init(struct sbi_scratch *scratch, u32 hartid, bool cold_boot)
hart_detect_features(scratch);
mstatus_init(scratch, hartid);
mstatus_init(scratch);
rc = fp_init(hartid);
rc = fp_init(scratch);
if (rc)
return rc;
rc = delegate_traps(scratch, hartid);
rc = delegate_traps(scratch);
if (rc)
return rc;

4
lib/sbi/sbi_init.c
View File

@@ -182,7 +182,7 @@ static void __noreturn init_coldboot(struct sbi_scratch *scratch, u32 hartid)
if (rc)
sbi_hart_hang();
rc = sbi_hart_init(scratch, hartid, TRUE);
rc = sbi_hart_init(scratch, TRUE);
if (rc)
sbi_hart_hang();
@@ -250,7 +250,7 @@ static void __noreturn init_warmboot(struct sbi_scratch *scratch, u32 hartid)
if (rc)
sbi_hart_hang();
rc = sbi_hart_init(scratch, hartid, FALSE);
rc = sbi_hart_init(scratch, FALSE);
if (rc)
sbi_hart_hang();