Firmware/opensbi
8
0
Fork 0
forked from Mirrors/opensbi
Code Pull Requests Activity

lib: fix is_region_valid()

Browse Source 
For 'reg->order == __riscv_xlen' the term 'BIT(reg->order)' is undefined.

Addresses-Coverity-ID: 1529706 ("Bad bit shift operation")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Xiang W <wxjstz@126.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
This commit is contained in:
Heinrich Schuchardt
2022-12-08 02:14:19 +01:00
committed by Anup Patel
parent ed8b8f5254
commit 8b00be6927
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/sbi/sbi_domain.c
View File

@@ -149,7 +149,7 @@ static bool is_region_valid(const struct sbi_domain_memregion *reg)
if (reg->order == __riscv_xlen && reg->base != 0)
return FALSE;
if (reg->base & (BIT(reg->order) - 1))
if (reg->order < __riscv_xlen && (reg->base & (BIT(reg->order) - 1)))
return FALSE;
return TRUE;