Files
opensbi/lib/utils/irqchip/imsic.c
T
Pawandeep OzaandAnup Patel b2ead3b037 lib: utils/irqchip/imsic: track IRQ enable state and restore EIE on warm init
Add an irq_state field to struct sbi_irqchip_hwirq_data with a single
IRQ_ENABLED flag (bit 0) to track whether a hardware interrupt has been
enabled via the irqchip framework. Set IRQ_ENABLED in
sbi_irqchip_unmask_hwirq() when the unmask callback is invoked.

Add sbi_irqchip_get_irq_state() as a private inline accessor and expose
sbi_irqchip_is_irq_enabled() as a public API for drivers to query the
enabled state of a hardware interrupt by chip pointer and hwirq number.

Refactor imsic_local_eix_update() to operate on a single interrupt ID
instead of a base+count range, simplifying the CSR bit manipulation to
a direct BIT(id) write without the inner loop. Update all call sites
accordingly.

Use sbi_irqchip_is_irq_enabled() in imsic_warm_irqchip_init() to
restore per-EIID EIE CSR state on warm boot and HSM resume based on
the saved irq_state, replacing the previous blanket disable of all
interrupts. This ensures that EIIDs enabled during hotplug/warminit
cycle are correctly re-enabled on the resuming hart without requiring
software to re-register or re-unmask each interrupt.

Signed-off-by: Oza Pawandeep <pawandeep.oza@oss.qualcomm.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
Link: https://lore.kernel.org/r/20260721214833.687361-6-pawandeep.oza@oss.qualcomm.com
Signed-off-by: Anup Patel <anup@brainfault.org>
2026-07-22 13:20:20 +05:30

626 lines
14 KiB
C

/*
* SPDX-License-Identifier: BSD-2-Clause
*
* Copyright (c) 2021 Western Digital Corporation or its affiliates.
* Copyright (c) 2022 Ventana Micro Systems Inc.
*
* Authors:
* Anup Patel <anup.patel@wdc.com>
*/
#include <sbi/riscv_asm.h>
#include <sbi/riscv_io.h>
#include <sbi/riscv_encoding.h>
#include <sbi/sbi_console.h>
#include <sbi/sbi_csr_detect.h>
#include <sbi/sbi_domain.h>
#include <sbi/sbi_ipi.h>
#include <sbi/sbi_irqchip.h>
#include <sbi/sbi_error.h>
#include <sbi/sbi_scratch.h>
#include <sbi_utils/irqchip/imsic.h>
#define IMSIC_MMIO_PAGE_LE 0x00
#define IMSIC_MMIO_PAGE_BE 0x04
#define IMSIC_MIN_ID 63
#define IMSIC_MAX_ID 2047
#define IMSIC_EIDELIVERY 0x70
#define IMSIC_EITHRESHOLD 0x72
#define IMSIC_TOPEI 0x76
#define IMSIC_TOPEI_ID_SHIFT 16
#define IMSIC_TOPEI_ID_MASK 0x7ff
#define IMSIC_TOPEI_PRIO_MASK 0x7ff
#define IMSIC_EIP0 0x80
#define IMSIC_EIP63 0xbf
#define IMSIC_EIPx_BITS 32
#define IMSIC_EIE0 0xc0
#define IMSIC_EIE63 0xff
#define IMSIC_EIEx_BITS 32
#define IMSIC_DISABLE_EIDELIVERY 0
#define IMSIC_ENABLE_EIDELIVERY 1
#define IMSIC_DISABLE_EITHRESHOLD 1
#define IMSIC_ENABLE_EITHRESHOLD 0
#define IMSIC_IPI_ID 1
#define imsic_csr_write(__c, __v) \
do { \
csr_write(CSR_MISELECT, __c); \
csr_write(CSR_MIREG, __v); \
} while (0)
#define imsic_csr_read(__c) \
({ \
unsigned long __v; \
csr_write(CSR_MISELECT, __c); \
__v = csr_read(CSR_MIREG); \
__v; \
})
#define imsic_csr_set(__c, __v) \
do { \
csr_write(CSR_MISELECT, __c); \
csr_set(CSR_MIREG, __v); \
} while (0)
#define imsic_csr_clear(__c, __v) \
do { \
csr_write(CSR_MISELECT, __c); \
csr_clear(CSR_MIREG, __v); \
} while (0)
static unsigned long imsic_ptr_offset;
#define imsic_get_hart_data_ptr(__scratch) \
sbi_scratch_read_type((__scratch), void *, imsic_ptr_offset)
#define imsic_set_hart_data_ptr(__scratch, __imsic) \
sbi_scratch_write_type((__scratch), void *, imsic_ptr_offset, (__imsic))
static unsigned long imsic_file_offset;
#define imsic_get_hart_file(__scratch) \
sbi_scratch_read_type((__scratch), long, imsic_file_offset)
#define imsic_set_hart_file(__scratch, __file) \
sbi_scratch_write_type((__scratch), long, imsic_file_offset, (__file))
int imsic_map_hartid_to_data(u32 hartid, struct imsic_data *imsic, int file)
{
struct sbi_scratch *scratch;
if (!imsic || !imsic->targets_mmode)
return SBI_EINVAL;
/*
* We don't need to fail if scratch pointer is not available
* because we might be dealing with hartid of a HART disabled
* in device tree. For HARTs disabled in device tree, the
* imsic_get_data() and imsic_get_target_file() will anyway
* fail.
*/
scratch = sbi_hartid_to_scratch(hartid);
if (!scratch)
return 0;
imsic_set_hart_data_ptr(scratch, imsic);
imsic_set_hart_file(scratch, file);
return 0;
}
struct imsic_data *imsic_get_data(u32 hartindex)
{
struct sbi_scratch *scratch;
if (!imsic_ptr_offset)
return NULL;
scratch = sbi_hartindex_to_scratch(hartindex);
if (!scratch)
return NULL;
return imsic_get_hart_data_ptr(scratch);
}
int imsic_get_target_file(u32 hartindex)
{
struct sbi_scratch *scratch;
if (!imsic_file_offset)
return SBI_ENOENT;
scratch = sbi_hartindex_to_scratch(hartindex);
if (!scratch)
return SBI_ENOENT;
return imsic_get_hart_file(scratch);
}
static int imsic_process_hwirqs(struct sbi_irqchip_device *chip)
{
struct imsic_data *imsic;
ulong mirq;
u32 hwirq;
int rc, ret = 0;
imsic = container_of(chip, struct imsic_data, irqchip);
if (!imsic || !imsic->targets_mmode)
return SBI_EINVAL;
if (imsic_get_data(current_hartindex()) != imsic)
return 0;
while ((mirq = csr_swap(CSR_MTOPEI, 0))) {
hwirq = (mirq >> IMSIC_TOPEI_ID_SHIFT) &
IMSIC_TOPEI_ID_MASK;
if (hwirq > imsic->num_ids) {
sbi_printf("%s: invalid hwirq=%lu num_ids=%lu\n",
__func__,
(unsigned long)hwirq,
(unsigned long)imsic->num_ids);
continue;
}
if (hwirq == IMSIC_IPI_ID) {
sbi_ipi_process();
continue;
}
rc = sbi_irqchip_process_hwirq(chip, hwirq);
if (rc && rc != SBI_ENOENT) {
sbi_printf("%s: hwirq=%lu failed rc=%d\n",
__func__,
(unsigned long)hwirq, rc);
ret = rc;
}
}
return ret;
}
static void imsic_ipi_send(u32 hart_index)
{
unsigned long reloff;
struct imsic_regs *regs;
struct imsic_data *data;
struct sbi_scratch *scratch;
int file;
scratch = sbi_hartindex_to_scratch(hart_index);
if (!scratch)
return;
data = imsic_get_hart_data_ptr(scratch);
file = imsic_get_hart_file(scratch);
if (!data || !data->targets_mmode)
return;
regs = &data->regs[0];
reloff = file * (1UL << data->guest_index_bits) * IMSIC_MMIO_PAGE_SZ;
while (regs->size && (regs->size <= reloff)) {
reloff -= regs->size;
regs++;
}
if (regs->size && (reloff < regs->size))
writel_relaxed(IMSIC_IPI_ID,
(void *)(regs->addr + reloff + IMSIC_MMIO_PAGE_LE));
}
static struct sbi_ipi_device imsic_ipi_device = {
.name = "aia-imsic",
.rating = 300,
.ipi_send = imsic_ipi_send
};
static void imsic_local_eix_update(unsigned long id,
bool pend, bool val)
{
unsigned long isel, ireg = 0;
isel = id / __riscv_xlen;
isel *= __riscv_xlen / IMSIC_EIPx_BITS;
isel += (pend) ? IMSIC_EIP0 : IMSIC_EIE0;
ireg |= BIT(id);
if (val)
imsic_csr_set(isel, ireg);
else
imsic_csr_clear(isel, ireg);
}
void imsic_local_irqchip_init(void)
{
struct sbi_trap_info trap = { 0 };
/*
* This function is expected to be called from:
* 1) nascent_init() platform callback which is called
* very early on each HART in boot-up path and and
* HSM resume path.
* 2) irqchip_init() platform callback which is called
* in boot-up path.
*/
/* If Smaia not available then do nothing */
csr_read_allowed(CSR_MTOPI, &trap);
if (trap.cause)
return;
/* Setup threshold to allow all enabled interrupts */
imsic_csr_write(IMSIC_EITHRESHOLD, IMSIC_ENABLE_EITHRESHOLD);
/* Enable interrupt delivery */
imsic_csr_write(IMSIC_EIDELIVERY, IMSIC_ENABLE_EIDELIVERY);
/* Enable IPI */
imsic_local_eix_update(IMSIC_IPI_ID, false, true);
}
static int imsic_warm_irqchip_init(struct sbi_irqchip_device *dev)
{
struct imsic_data *imsic;
struct imsic_data *hart_imsic;
int i;
imsic = container_of(dev, struct imsic_data, irqchip);
hart_imsic = imsic_get_data(current_hartindex());
/* Sanity checks */
if (!hart_imsic || hart_imsic != imsic ||
!hart_imsic->targets_mmode)
return SBI_EINVAL;
/* enable interrutps based on the irq state */
for (i = 1; i < imsic->num_ids; i++) {
if (sbi_irqchip_is_hwirq_enabled(&imsic->irqchip, i) == true)
imsic_local_eix_update(i, true, true);
else
imsic_local_eix_update(i, false, false);
}
/* Clear IPI pending */
imsic_local_eix_update(IMSIC_IPI_ID, true, false);
/* Local IMSIC initialization */
imsic_local_irqchip_init();
return 0;
}
int imsic_data_check(struct imsic_data *imsic)
{
u32 i, tmp;
unsigned long base_addr, addr, mask;
/* Sanity checks */
if (!imsic ||
(imsic->num_ids < IMSIC_MIN_ID) ||
(IMSIC_MAX_ID < imsic->num_ids))
return SBI_EINVAL;
tmp = BITS_PER_LONG - IMSIC_MMIO_PAGE_SHIFT;
if (tmp < imsic->guest_index_bits)
return SBI_EINVAL;
tmp = BITS_PER_LONG - IMSIC_MMIO_PAGE_SHIFT -
imsic->guest_index_bits;
if (tmp < imsic->hart_index_bits)
return SBI_EINVAL;
tmp = BITS_PER_LONG - IMSIC_MMIO_PAGE_SHIFT -
imsic->guest_index_bits - imsic->hart_index_bits;
if (tmp < imsic->group_index_bits)
return SBI_EINVAL;
tmp = IMSIC_MMIO_PAGE_SHIFT + imsic->guest_index_bits +
imsic->hart_index_bits;
if (imsic->group_index_shift < tmp)
return SBI_EINVAL;
tmp = imsic->group_index_bits + imsic->group_index_shift - 1;
if (tmp >= BITS_PER_LONG)
return SBI_EINVAL;
/*
* Number of interrupt identities should be 1 less than
* multiple of 63
*/
if ((imsic->num_ids & IMSIC_MIN_ID) != IMSIC_MIN_ID)
return SBI_EINVAL;
/* We should have at least one regset */
if (!imsic->regs[0].size)
return SBI_EINVAL;
/* Match patter of each regset */
base_addr = imsic->regs[0].addr;
base_addr &= ~((1UL << (imsic->guest_index_bits +
imsic->hart_index_bits +
IMSIC_MMIO_PAGE_SHIFT)) - 1);
base_addr &= ~(((1UL << imsic->group_index_bits) - 1) <<
imsic->group_index_shift);
for (i = 0; i < IMSIC_MAX_REGS && imsic->regs[i].size; i++) {
mask = (1UL << imsic->guest_index_bits) * IMSIC_MMIO_PAGE_SZ;
mask -= 1UL;
if (imsic->regs[i].size & mask)
return SBI_EINVAL;
addr = imsic->regs[i].addr;
addr &= ~((1UL << (imsic->guest_index_bits +
imsic->hart_index_bits +
IMSIC_MMIO_PAGE_SHIFT)) - 1);
addr &= ~(((1UL << imsic->group_index_bits) - 1) <<
imsic->group_index_shift);
if (base_addr != addr)
return SBI_EINVAL;
}
return 0;
}
static int imsic_hwirq_setup(struct sbi_irqchip_device *chip, u32 hwirq, u32 hwirq_flags)
{
if (hwirq_flags != SBI_HWIRQ_FLAGS_NONE)
return SBI_ENOTSUPP;
sbi_irqchip_set_raw_handler(chip, hwirq,
sbi_irqchip_raw_handler_default);
return 0;
}
static void imsic_hwirq_cleanup(struct sbi_irqchip_device *chip, u32 hwirq)
{
struct imsic_data *imsic;
if (!chip)
return;
imsic = container_of(chip, struct imsic_data, irqchip);
if (!imsic || !imsic->targets_mmode)
return;
imsic_local_eix_update(hwirq, false, false);
imsic_local_eix_update(hwirq, true, false);
}
static void imsic_hwirq_eoi(struct sbi_irqchip_device *chip, u32 hwirq)
{
/*
* IMSIC interrupt claim/ack is already done by reading CSR_MTOPEI
* in imsic_process_hwirqs(). No extra EOI operation is required.
*/
}
static int imsic_compose_msi_msg(struct imsic_data *imsic,
u32 hart_index, u32 eiid,
struct sbi_irqchip_msi_msg *msg)
{
struct imsic_regs *regs;
unsigned long reloff;
u64 msi_addr;
int file;
if (!imsic || !msg)
return SBI_EINVAL;
if (!eiid || eiid == IMSIC_IPI_ID)
return 0;
file = imsic_get_target_file(hart_index);
if (file < 0) {
sbi_printf("%s: no file for hart=%lu rc=%d\n",
__func__,
(unsigned long)hart_index, file);
return file;
}
regs = &imsic->regs[0];
reloff = file * (1UL << imsic->guest_index_bits) * IMSIC_MMIO_PAGE_SZ;
while (regs->size && regs->size <= reloff) {
reloff -= regs->size;
regs++;
}
if (!regs->size || regs->size <= reloff) {
sbi_printf("%s: no regset for hart=%lu file=%d reloff=0x%lx\n",
__func__,
(unsigned long)hart_index, file, reloff);
return SBI_ENODEV;
}
msi_addr = (u64)regs->addr + reloff + IMSIC_MMIO_PAGE_LE;
msg->address_lo = (u32)(msi_addr);
msg->address_hi = (u32)(msi_addr >> 32);
msg->data = eiid;
return 0;
}
static int imsic_program_msi(struct sbi_irqchip_device *chip,
u32 eiid, u32 hart_index)
{
struct imsic_data *imsic;
struct sbi_irqchip_msi_msg msg;
int rc;
if (!chip)
return SBI_EINVAL;
imsic = imsic_get_data(hart_index);
if (!imsic || !imsic->targets_mmode)
return SBI_ENODEV;
rc = imsic_compose_msi_msg(imsic, hart_index, eiid, &msg);
if (rc) {
sbi_printf("%s: compose failed eiid=%lu hart=%lu rc=%d\n",
__func__,
(unsigned long)eiid,
(unsigned long)hart_index, rc);
}
rc = sbi_irqchip_write_msi(chip, eiid, &msg);
if (rc) {
sbi_printf("%s: write_msi failed eiid=%lu hart=%lu rc=%d\n",
__func__,
(unsigned long)eiid,
(unsigned long)hart_index, rc);
return rc;
}
return 0;
}
static int imsic_hwirq_set_affinity(struct sbi_irqchip_device *chip,
u32 hwirq, u32 hart_index)
{
struct imsic_data *imsic;
int rc;
if (!chip)
return SBI_EINVAL;
imsic = container_of(chip, struct imsic_data, irqchip);
if (!imsic || !imsic->targets_mmode)
return SBI_EINVAL;
if (!hwirq || hwirq == IMSIC_IPI_ID)
return 0;
if (!sbi_hartmask_test_hartindex(hart_index, &chip->target_harts))
return SBI_EINVAL;
rc = imsic_program_msi(chip, hwirq, hart_index);
if (rc) {
sbi_printf("%s: failed hwirq=%lu hart=%lu rc=%d\n",
__func__,
(unsigned long)hwirq,
(unsigned long)hart_index, rc);
return rc;
}
return 0;
}
static void imsic_hwirq_mask(struct sbi_irqchip_device *chip, u32 hwirq)
{
struct imsic_data *imsic;
if (!chip)
return;
imsic = container_of(chip, struct imsic_data, irqchip);
if (!imsic || !imsic->targets_mmode)
return;
imsic_local_eix_update(hwirq, false, false);
}
static void imsic_hwirq_unmask(struct sbi_irqchip_device *chip, u32 hwirq)
{
struct imsic_data *imsic;
if (!chip)
return;
imsic = container_of(chip, struct imsic_data, irqchip);
if (!imsic || !imsic->targets_mmode)
return;
if (!hwirq || hwirq == IMSIC_IPI_ID)
return;
imsic_local_eix_update(hwirq, false, true);
}
static struct sbi_irqchip_device imsic_device = {
.warm_init = imsic_warm_irqchip_init,
.process_hwirqs = imsic_process_hwirqs,
.hwirq_setup = imsic_hwirq_setup,
.hwirq_cleanup = imsic_hwirq_cleanup,
.hwirq_eoi = imsic_hwirq_eoi,
.hwirq_set_affinity = imsic_hwirq_set_affinity,
.hwirq_mask = imsic_hwirq_mask,
.hwirq_unmask = imsic_hwirq_unmask,
};
int imsic_cold_irqchip_init(struct imsic_data *imsic)
{
int i, rc;
/* Sanity checks */
rc = imsic_data_check(imsic);
if (rc)
return rc;
/* We only initialize M-mode IMSIC */
if (!imsic->targets_mmode)
return SBI_EINVAL;
/* Allocate scratch space pointer */
if (!imsic_ptr_offset) {
imsic_ptr_offset = sbi_scratch_alloc_type_offset(void *);
if (!imsic_ptr_offset)
return SBI_ENOMEM;
}
/* Allocate scratch space file */
if (!imsic_file_offset) {
imsic_file_offset = sbi_scratch_alloc_type_offset(long);
if (!imsic_file_offset)
return SBI_ENOMEM;
}
/* Add IMSIC regions to the root domain */
for (i = 0; i < IMSIC_MAX_REGS && imsic->regs[i].size; i++) {
rc = sbi_domain_root_add_memrange(imsic->regs[i].addr,
imsic->regs[i].size,
IMSIC_MMIO_PAGE_SZ,
SBI_DOMAIN_MEMREGION_MMIO |
SBI_DOMAIN_MEMREGION_M_READABLE |
SBI_DOMAIN_MEMREGION_M_WRITABLE);
if (rc)
return rc;
}
imsic->irqchip = imsic_device;
imsic->irqchip.id = imsic->unique_id;
imsic_device.caps = SBI_IRQCHIP_CAPS_MSI;
imsic->irqchip.num_hwirq = imsic->num_ids + 1;
sbi_hartmask_set_all(&imsic->irqchip.target_harts);
/* Register irqchip device */
rc = sbi_irqchip_add_device(&imsic->irqchip);
if (rc) {
sbi_printf("%s: sbi_irqchip_add_device failed rc=%d\n",
__func__, rc);
return rc;
}
rc = sbi_irqchip_register_reserved(&imsic->irqchip, 0, IMSIC_IPI_ID + 1);
if (rc) {
sbi_printf("%s: register_reserved failed rc=%d\n",
__func__, rc);
return rc;
}
/* Register IPI device */
sbi_ipi_add_device(&imsic_ipi_device);
return 0;
}