mirror of
https://github.com/riscv-software-src/opensbi.git
synced 2026-11-19 10:21:38 +00:00
sbi_ecall_pmu_handler() passes the uninitialized local temp to sbi_pmu_ctr_fw_read() and copies it into out->value unconditionally. sbi_pmu_ctr_fw_read() only writes *cval on success, so every error return of SBI_EXT_PMU_COUNTER_FW_READ (e.g. a hardware or inactive counter index) hands an M-mode stack word to the supervisor in a1. SBI_EXT_PMU_COUNTER_FW_READ_HI does the same with the upper half of temp on RV32. Initialize temp to zero so that the error paths return zero in sbiret.value; the success paths are unchanged. Fixes:1664d0efce("lib: sbi_pmu: Replace sbi_pmu_ctr_read() with sbi_pmu_ctr_fw_read()") Fixes:51951d9e9a("lib: sbi_pmu: Implement sbi_pmu_counter_fw_read_hi") Signed-off-by: Nickolai Zeldovich <nickolai@csail.mit.edu> Assisted-By: Claude Fable 5.1 Reviewed-by: Anup Patel <anup@brainfault.org> Link: https://lore.kernel.org/r/20261011222115.769450-1-nickolai@csail.mit.edu Signed-off-by: Anup Patel <anup@brainfault.org>