Firmware/opensbi
8
0
Fork 0
forked from Mirrors/opensbi
Code Pull Requests Activity

lib: sbi: verbose sbi_domain_root_add_memregion

Browse Source 
Be more verbose on region confict, print addresses in conflict.

Signed-off-by: Nikita Shubin <n.shubin@yadro.com>
Reviewed-by: Xiang W <wxjstz@126.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
This commit is contained in:
Nikita Shubin
2022-02-11 14:11:54 +03:00
committed by Anup Patel
parent 3a69cc1487
commit f2ccf2f783
2 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
include/sbi/sbi_domain.h
View File

@@ -174,7 +174,9 @@ int sbi_domain_register(struct sbi_domain *dom,
* Add a memory region to the root domain * Add a memory region to the root domain
* @param reg pointer to the memory region to be added * @param reg pointer to the memory region to be added
* *
* @return 0 on success and negative error code on failure * @return 0 on success
* @return SBI_EALREADY if memory region conflicts with existing
* @return SBI_EINVAL otherwise
*/ */
int sbi_domain_root_add_memregion(const struct sbi_domain_memregion *reg); int sbi_domain_root_add_memregion(const struct sbi_domain_memregion *reg);

8
lib/sbi/sbi_domain.c
View File

@@ -471,8 +471,12 @@ int sbi_domain_root_add_memregion(const struct sbi_domain_memregion *reg)
/* Check for conflicts */ /* Check for conflicts */
sbi_domain_for_each_memregion(&root, nreg) { sbi_domain_for_each_memregion(&root, nreg) {
if (is_region_conflict(reg, nreg)) if (is_region_conflict(reg, nreg)) {
return SBI_EINVAL; sbi_printf("%s: is_region_conflict check failed"
" 0x%lx conflicts existing 0x%lx\n", __func__,
reg->base, nreg->base);
return SBI_EALREADY;
}
} }
/* Append the memregion to root memregions */ /* Append the memregion to root memregions */