Firmware/opensbi
8
0
Fork 0
forked from Mirrors/opensbi
Code Pull Requests Activity

lib: sbi: Simplify ipi platform operations

Browse Source 
Instead of having ipi_send() and ipi_clear() callbacks in
platform operations, it will be much simpler for ipi driver
to directly register these operations as a device to sbi_ipi
implementation.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
This commit is contained in:
Anup Patel
2021-04-22 10:27:15 +05:30
committed by Anup Patel
parent 559a8f1d3b
commit dc39c7b630
18 changed files with 72 additions and 109 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
lib/utils/ipi/fdt_ipi.c
View File

@@ -17,35 +17,15 @@ static struct fdt_ipi *ipi_drivers[] = {
&fdt_ipi_clint
};
static void dummy_send(u32 target_hart)
{
}
static void dummy_clear(u32 target_hart)
{
}
static struct fdt_ipi dummy = {
.match_table = NULL,
.cold_init = NULL,
.warm_init = NULL,
.exit = NULL,
.send = dummy_send,
.clear = dummy_clear
};
static struct fdt_ipi *current_driver = &dummy;
void fdt_ipi_send(u32 target_hart)
{
current_driver->send(target_hart);
}
void fdt_ipi_clear(u32 target_hart)
{
current_driver->clear(target_hart);
}
void fdt_ipi_exit(void)
{
if (current_driver->exit)

2
lib/utils/ipi/fdt_ipi_clint.c
View File

@@ -45,6 +45,4 @@ struct fdt_ipi fdt_ipi_clint = {
.cold_init = ipi_clint_cold_init,
.warm_init = clint_warm_ipi_init,
.exit = NULL,
.send = clint_ipi_send,
.clear = clint_ipi_clear,
};

20
lib/utils/sys/clint.c
View File

@@ -13,6 +13,7 @@
#include <sbi/sbi_domain.h>
#include <sbi/sbi_error.h>
#include <sbi/sbi_hartmask.h>
#include <sbi/sbi_ipi.h>
#include <sbi/sbi_timer.h>
#include <sbi_utils/sys/clint.h>
@@ -27,7 +28,7 @@
static struct clint_data *clint_ipi_hartid2data[SBI_HARTMASK_MAX_BITS];
void clint_ipi_send(u32 target_hart)
static void clint_ipi_send(u32 target_hart)
{
struct clint_data *clint;
@@ -41,7 +42,7 @@ void clint_ipi_send(u32 target_hart)
writel(1, &clint->ipi[target_hart - clint->first_hartid]);
}
void clint_ipi_clear(u32 target_hart)
static void clint_ipi_clear(u32 target_hart)
{
struct clint_data *clint;
@@ -55,6 +56,12 @@ void clint_ipi_clear(u32 target_hart)
writel(0, &clint->ipi[target_hart - clint->first_hartid]);
}
static struct sbi_ipi_device clint_ipi = {
.name = "clint",
.ipi_send = clint_ipi_send,
.ipi_clear = clint_ipi_clear
};
int clint_warm_ipi_init(void)
{
/* Clear CLINT IPI for current HART */
@@ -66,6 +73,7 @@ int clint_warm_ipi_init(void)
int clint_cold_ipi_init(struct clint_data *clint)
{
u32 i;
int rc;
struct sbi_domain_memregion reg;
if (!clint)
@@ -82,7 +90,13 @@ int clint_cold_ipi_init(struct clint_data *clint)
sbi_domain_memregion_init(clint->addr + CLINT_IPI_OFF,
CLINT_IPI_SIZE,
SBI_DOMAIN_MEMREGION_MMIO, &reg);
return sbi_domain_root_add_memregion(&reg);
rc = sbi_domain_root_add_memregion(&reg);
if (rc)
return rc;
sbi_ipi_set_device(&clint_ipi);
return 0;
}
static struct clint_data *clint_timer_hartid2data[SBI_HARTMASK_MAX_BITS];