Firmware/opensbi
8
0
Fork 0
forked from Mirrors/opensbi
Code Pull Requests Activity

scripts/carray.sh: Avoid useless use of cat

Browse Source 
awk(1) takes input files as positional arguments, so there is no need
to read the file with cat(1).

Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
This commit is contained in:
Samuel Holland
2024-11-11 14:02:47 -08:00
committed by Anup Patel
parent 1ccc52c427
commit bb008e5d27
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
scripts/carray.sh
View File

@@ -43,19 +43,19 @@ if [ ! -f "${CONFIG_FILE}" ]; then
usage usage
fi fi
TYPE_HEADER=`cat ${CONFIG_FILE} | awk '{ if ($1 == "HEADER:") { printf $2; exit 0; } }'` TYPE_HEADER=$(awk '{ if ($1 == "HEADER:") { printf $2; exit 0; } }' "${CONFIG_FILE}")
if [ -z "${TYPE_HEADER}" ]; then if [ -z "${TYPE_HEADER}" ]; then
echo "Must specify HEADER: in input config file" echo "Must specify HEADER: in input config file"
usage usage
fi fi
TYPE_NAME=`cat ${CONFIG_FILE} | awk '{ if ($1 == "TYPE:") { printf $2; for (i=3; i<=NF; i++) printf " %s", $i; exit 0; } }'` TYPE_NAME=$(awk '{ if ($1 == "TYPE:") { printf $2; for (i=3; i<=NF; i++) printf " %s", $i; exit 0; } }' "${CONFIG_FILE}")
if [ -z "${TYPE_NAME}" ]; then if [ -z "${TYPE_NAME}" ]; then
echo "Must specify TYPE: in input config file" echo "Must specify TYPE: in input config file"
usage usage
fi fi
ARRAY_NAME=`cat ${CONFIG_FILE} | awk '{ if ($1 == "NAME:") { printf $2; exit 0; } }'` ARRAY_NAME=$(awk '{ if ($1 == "NAME:") { printf $2; exit 0; } }' "${CONFIG_FILE}")
if [ -z "${ARRAY_NAME}" ]; then if [ -z "${ARRAY_NAME}" ]; then
echo "Must specify NAME: in input config file" echo "Must specify NAME: in input config file"
usage usage