Firmware/opensbi
8
0
Fork 0
forked from Mirrors/opensbi
Code Pull Requests Activity

lib: sbi_hsm: Move misplaced comment

Browse Source 
While non-retentive suspend is not allowed for M-mode, the comment
at the top of sbi_hsm_hart_suspend() implied suspend wasn't allowed
for M-mode at all. Move the comment above the mode check which is
inside a suspend type is non-retentive check.

Signed-off-by: Andrew Jones <ajones@ventanamicro.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
This commit is contained in:
Andrew Jones
2023-02-27 11:30:59 +01:00
committed by Anup Patel
parent c88e039ec2
commit b1ae6ef33b
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/sbi/sbi_hsm.c
View File

@@ -398,8 +398,6 @@ int sbi_hsm_hart_suspend(struct sbi_scratch *scratch, u32 suspend_type,
struct sbi_hsm_data *hdata = sbi_scratch_offset_ptr(scratch, struct sbi_hsm_data *hdata = sbi_scratch_offset_ptr(scratch,
hart_data_offset); hart_data_offset);
/* For now, we only allow suspend from S-mode or U-mode. */
/* Sanity check on domain assigned to current HART */ /* Sanity check on domain assigned to current HART */
if (!dom) if (!dom)
return SBI_EFAIL; return SBI_EFAIL;
@@ -414,6 +412,10 @@ int sbi_hsm_hart_suspend(struct sbi_scratch *scratch, u32 suspend_type,
/* Additional sanity check for non-retentive suspend */ /* Additional sanity check for non-retentive suspend */
if (suspend_type & SBI_HSM_SUSP_NON_RET_BIT) { if (suspend_type & SBI_HSM_SUSP_NON_RET_BIT) {
/*
* For now, we only allow non-retentive suspend from
* S-mode or U-mode.
*/
if (rmode != PRV_S && rmode != PRV_U) if (rmode != PRV_S && rmode != PRV_U)
return SBI_EFAIL; return SBI_EFAIL;
if (dom && !sbi_domain_check_addr(dom, raddr, rmode, if (dom && !sbi_domain_check_addr(dom, raddr, rmode,