Firmware/opensbi
8
0
Fork 0
forked from Mirrors/opensbi
Code Pull Requests Activity

lib: utils/irqchip: Use sbi_domain_root_add_memrange() for IMSIC

Browse Source 
The sbi_domain_root_add_memrange() should be preferred for creating
multiple memregions over a range. Update IMSIC driver to use
sbi_domain_root_add_memrange() instead of explicitly registering
memregions.

Signed-off-by: Anup Patel <apatel@ventanamicro.com>
Reviewed-by: Samuel Holland <samuel.holland@sifive.com>
This commit is contained in:
Anup Patel
2024-09-20 14:15:55 +05:30
committed by Anup Patel
parent 8576ca4234
commit abc68e881d
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
lib/utils/irqchip/imsic.c
View File

@@ -348,7 +348,6 @@ int imsic_data_check(struct imsic_data *imsic)
int imsic_cold_irqchip_init(struct imsic_data *imsic) int imsic_cold_irqchip_init(struct imsic_data *imsic)
{ {
int i, rc; int i, rc;
struct sbi_domain_memregion reg;
/* Sanity checks */ /* Sanity checks */
rc = imsic_data_check(imsic); rc = imsic_data_check(imsic);
@@ -378,13 +377,12 @@ int imsic_cold_irqchip_init(struct imsic_data *imsic)
/* Add IMSIC regions to the root domain */ /* Add IMSIC regions to the root domain */
for (i = 0; i < IMSIC_MAX_REGS && imsic->regs[i].size; i++) { for (i = 0; i < IMSIC_MAX_REGS && imsic->regs[i].size; i++) {
sbi_domain_memregion_init(imsic->regs[i].addr, rc = sbi_domain_root_add_memrange(imsic->regs[i].addr,
imsic->regs[i].size, imsic->regs[i].size,
(SBI_DOMAIN_MEMREGION_MMIO | IMSIC_MMIO_PAGE_SZ,
SBI_DOMAIN_MEMREGION_M_READABLE | SBI_DOMAIN_MEMREGION_MMIO |
SBI_DOMAIN_MEMREGION_M_WRITABLE), SBI_DOMAIN_MEMREGION_M_READABLE |
&reg); SBI_DOMAIN_MEMREGION_M_WRITABLE);
rc = sbi_domain_root_add_memregion(&reg);
if (rc) if (rc)
return rc; return rc;
} }