Firmware/opensbi
8
0
Fork 0
forked from Mirrors/opensbi
Code Pull Requests Activity

lib: More improvements to sbi_fifo

Browse Source 
This patch does following improvements to sbi_fifo:
1. Use valid SBI_Exxxx error codes instead of -1
2. The sbi_fifo_is_full() and sbi_fifo_is_empty() did
   not acquire qlock before accessing head and tail
   hence fixed it
3. Added avail member for ease in debugging and simplifying
   head/tail updates.

Due to above changes size of sbi_fifo changes from 48 bytes
to 56 bytes.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
This commit is contained in:
Anup Patel
2019-04-03 10:24:03 +05:30
committed by Atish Patra
parent 6dc1b0f6e2
commit 9dc95021db
4 changed files with 73 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
include/sbi/sbi_error.h
View File

@@ -21,5 +21,6 @@
#define SBI_ETIMEDOUT -8
#define SBI_EIO -9
#define SBI_EILL -10
#define SBI_ENOSPC -11
#endif

18
include/sbi/sbi_fifo.h
View File

@@ -15,18 +15,22 @@
#include <sbi/sbi_types.h>
struct sbi_fifo {
int head;
int tail;
spinlock_t qlock;
unsigned long entrysize;
unsigned long num_entries;
/* Static members of struct */
void *queue;
unsigned long entry_size;
unsigned long num_entries;
/* Dynamic members of struct protected by lock */
spinlock_t qlock;
unsigned long avail;
unsigned long head;
unsigned long tail;
};
int sbi_fifo_dequeue(struct sbi_fifo *fifo, void *data);
int sbi_fifo_enqueue(struct sbi_fifo *fifo, void *data);
void sbi_fifo_init(struct sbi_fifo *fifo, unsigned long entries,
unsigned long entrysize);
void sbi_fifo_init(struct sbi_fifo *fifo, void *queue_mem,
unsigned long entries, unsigned long entry_size);
bool sbi_fifo_is_empty(struct sbi_fifo *fifo);
bool sbi_fifo_is_full(struct sbi_fifo *fifo);
#endif