Firmware/opensbi
8
0
Fork 0
forked from Mirrors/opensbi
Code Pull Requests Activity

lib: utils/irqchip: plic: Ensure no out-of-bound access in context save/restore helpers

Browse Source 
Currently the context save/restore helpers writes/reads the provided
array using an index whose maximum value is determined by PLIC, which
potentially may disagree with the caller to these helpers.

Add a parameter to ask the caller to provide the size limit of the
array to ensure no out-of-bound access happens.

Signed-off-by: Bin Meng <bmeng@tinylab.org>
Reviewed-by: Anup Patel <anup@brainfault.org>
This commit is contained in:
Bin Meng
2022-12-11 14:54:24 +08:00
committed by Anup Patel
parent fabbc00668
commit 9a2eeb4aae
5 changed files with 23 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
lib/utils/irqchip/plic.c
View File

@@ -92,22 +92,28 @@ static void plic_set_ie(const struct plic_data *plic, u32 cntxid,
}
void plic_context_save(const struct plic_data *plic, int context_id,
u32 *enable, u32 *threshold)
u32 *enable, u32 *threshold, u32 num)
{
u32 ie_words = plic->num_src / 32 + 1;
for (u32 i = 0; i < ie_words; i++)
if (num > ie_words)
num = ie_words;
for (u32 i = 0; i < num; i++)
enable[i] = plic_get_ie(plic, context_id, i);
*threshold = plic_get_thresh(plic, context_id);
}
void plic_context_restore(const struct plic_data *plic, int context_id,
const u32 *enable, u32 threshold)
const u32 *enable, u32 threshold, u32 num)
{
u32 ie_words = plic->num_src / 32 + 1;
for (u32 i = 0; i < ie_words; i++)
if (num > ie_words)
num = ie_words;
for (u32 i = 0; i < num; i++)
plic_set_ie(plic, context_id, i, enable[i]);
plic_set_thresh(plic, context_id, threshold);