Firmware/opensbi
8
0
Fork 0
forked from Mirrors/opensbi
Code Pull Requests Activity

lib: utils: Simplify SET_ISA_EXT_MAP()

Browse Source 
The define is hard to read. The continue statement does not do what was
intended.

* Remove do {} while (false);
* Change the name to set_multi_letter_ext
  - Other local macros are lower case too.
  - Refer to the fact that this is only used for multi-letter extensions.

Addresses-Coverity-ID: 1568359 Unexpected control flow
Fixes: d72f5f1747 ("lib: utils: Add detection of Smepmp from ISA string in FDT")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Xiang W <wxjstz@126.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
This commit is contained in:
Heinrich Schuchardt
2023-09-28 14:17:20 +02:00
committed by Anup Patel
parent 9da30f6105
commit 942aca232e
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/utils/fdt/fdt_helper.c
View File

@@ -369,16 +369,14 @@ static int fdt_parse_isa_one_hart(const char *isa, unsigned long *extensions)
if (!j)
continue;
#define SET_ISA_EXT_MAP(name, bit) \
do { \
#define set_multi_letter_ext(name, bit) \
if (!strcmp(mstr, name)) { \
__set_bit(bit, extensions); \
continue; \
} \
} while (false) \
}
SET_ISA_EXT_MAP("smepmp", SBI_HART_EXT_SMEPMP);
#undef SET_ISA_EXT_MAP
set_multi_letter_ext("smepmp", SBI_HART_EXT_SMEPMP);
#undef set_multi_letter_ext
}
return 0;