Firmware/opensbi
8
0
Fork 0
forked from Mirrors/opensbi
Code Pull Requests Activity

lib:platform: Fix sbi_getc return type.

Browse Source 
As per the current SBI specification, sbi_getc should return
an int instead of char.

In case of FIFO is empty, return -1 as per the specification.

Reported-by: Sergi Granell <xerpi.g.12@gmail.com>
Suggested-by:Thadeu Lima de Souza Cascardo <cascardo@cascardo.eti.br>
Signed-off-by: Atish Patra <atish.patra@wdc.com>
This commit is contained in:
Atish Patra
2019-02-27 17:42:17 -08:00
committed by Anup Patel
parent 05602e2bf4
commit 86cc9b8633
11 changed files with 20 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/sbi/sbi_console.h
View File

@@ -16,7 +16,7 @@
bool sbi_isprintable(char ch);
char sbi_getc(void);
int sbi_getc(void);
void sbi_putc(char ch);

6
include/sbi/sbi_platform.h
View File

@@ -77,7 +77,7 @@ struct sbi_platform {
/** Write a character to the platform console output */
void (*console_putc)(char ch);
/** Read a character from the platform console input */
char (*console_getc)(void);
int (*console_getc)(void);
/** Initialize the platform console */
int (*console_init)(void);
@@ -283,11 +283,11 @@ static inline void sbi_platform_console_putc(struct sbi_platform *plat,
*
* @return character read from console input
*/
static inline char sbi_platform_console_getc(struct sbi_platform *plat)
static inline int sbi_platform_console_getc(struct sbi_platform *plat)
{
if (plat && plat->console_getc)
return plat->console_getc();
return 0;
return -1;
}
/**