Firmware/opensbi
8
0
Fork 0
forked from Mirrors/opensbi
Code Pull Requests Activity

lib: utils/ipi: Use sbi_domain_root_add_memrange() for ACLINT mswi

Browse Source 
The sbi_domain_root_add_memrange() should be preferred for creating
multiple memregions over a range. Update ACLINT mswi driver to use
sbi_domain_root_add_memrange() instead of explicitly registering
memregions.

Signed-off-by: Anup Patel <apatel@ventanamicro.com>
Reviewed-by: Samuel Holland <samuel.holland@sifive.com>
This commit is contained in:
Anup Patel
2024-09-20 10:14:46 +05:30
committed by Anup Patel
parent 2ffa0a153d
commit 8576ca4234
1 changed files with 6 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
lib/utils/ipi/aclint_mswi.c
View File

@@ -84,8 +84,6 @@ int aclint_mswi_cold_init(struct aclint_mswi_data *mswi)
u32 i; u32 i;
int rc; int rc;
struct sbi_scratch *scratch; struct sbi_scratch *scratch;
unsigned long pos, region_size;
struct sbi_domain_memregion reg;
/* Sanity checks */ /* Sanity checks */
if (!mswi || (mswi->addr & (ACLINT_MSWI_ALIGN - 1)) || if (!mswi || (mswi->addr & (ACLINT_MSWI_ALIGN - 1)) ||
@@ -114,18 +112,12 @@ int aclint_mswi_cold_init(struct aclint_mswi_data *mswi)
} }
/* Add MSWI regions to the root domain */ /* Add MSWI regions to the root domain */
for (pos = 0; pos < mswi->size; pos += ACLINT_MSWI_ALIGN) { rc = sbi_domain_root_add_memrange(mswi->addr, mswi->size, ACLINT_MSWI_ALIGN,
region_size = ((mswi->size - pos) < ACLINT_MSWI_ALIGN) ? SBI_DOMAIN_MEMREGION_MMIO |
(mswi->size - pos) : ACLINT_MSWI_ALIGN; SBI_DOMAIN_MEMREGION_M_READABLE |
sbi_domain_memregion_init(mswi->addr + pos, region_size, SBI_DOMAIN_MEMREGION_M_WRITABLE);
(SBI_DOMAIN_MEMREGION_MMIO | if (rc)
SBI_DOMAIN_MEMREGION_M_READABLE | return rc;
SBI_DOMAIN_MEMREGION_M_WRITABLE),
&reg);
rc = sbi_domain_root_add_memregion(&reg);
if (rc)
return rc;
}
sbi_ipi_set_device(&aclint_mswi); sbi_ipi_set_device(&aclint_mswi);