Firmware/opensbi
8
0
Fork 0
forked from Mirrors/opensbi
Code Pull Requests Activity

lib: utils/serial: Fix semihosting compile error using LLVM

Browse Source 
We fix the following semihosting compile error observed using LLVM:
lib/utils/serial/semihosting.c:158:12: error: result of comparison of constant -1 with expression of type 'char' is always true [-Werror,-Wtautological-constant-out-of-range-compare]
                ret = ch > -1 ? ch : -1;
                      ~~ ^ ~~

Fixes: 7f09fba86e ("lib: utils/serial: add semihosting support")
Signed-off-by: Anup Patel <apatel@ventanamicro.com>
Reviewed-by: Xiang W <wxjstz@126.com>
Reviewed-by: Bin Meng <bmeng@tinylab.org>
This commit is contained in:
Anup Patel
2022-11-08 17:40:16 +05:30
committed by Anup Patel
parent 8e9966c1a7
commit 7b29264f11
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/utils/serial/semihosting.c
View File

@@ -154,8 +154,8 @@ static int semihosting_getc(void)
int ret;
if (semihosting_infd < 0) {
ch = semihosting_trap(SYSREADC, NULL);
ret = ch > -1 ? ch : -1;
ret = semihosting_trap(SYSREADC, NULL);
ret = ret < 0 ? -1 : ret;
} else
ret = semihosting_read(semihosting_infd, &ch, 1) > 0 ? ch : -1;