Firmware/opensbi
8
0
Fork 0
forked from Mirrors/opensbi
Code Pull Requests Activity

include: sbi_platform: Remove priv parameter from hart_start() callback

Browse Source 
The priv parameter in hart_start() platform callback is redundant hence
we remove it.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
Reviewed-by: Atish Patra <atish.patra@wdc.com>
This commit is contained in:
Anup Patel
2020-03-20 16:44:38 +05:30
committed by Anup Patel
parent 40b221baff
commit 7b211ff924
2 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
include/sbi/sbi_platform.h
View File

@@ -138,8 +138,8 @@ struct sbi_platform_operations {
/** Exit platform timer for current HART */ /** Exit platform timer for current HART */
void (*timer_exit)(void); void (*timer_exit)(void);
/** Bringup the given hart from previous stage **/ /** Bringup the given hart */
int (*hart_start)(u32 hartid, ulong saddr, ulong priv); int (*hart_start)(u32 hartid, ulong saddr);
/** /**
* Stop the current hart from running. This call doesn't expect to * Stop the current hart from running. This call doesn't expect to
* return if success. * return if success.
@@ -346,18 +346,16 @@ static inline bool sbi_platform_hart_invalid(const struct sbi_platform *plat,
* a generic WFI based approach will be used to start/stop a hart in OpenSBI. * a generic WFI based approach will be used to start/stop a hart in OpenSBI.
* *
* @param plat pointer to struct sbi_platform * @param plat pointer to struct sbi_platform
* @param hartid Hart ID * @param hartid HART id
* @param saddr Physical address in supervisor mode for hart to jump after * @param saddr M-mode start physical address for the HART
* OpenSBI
* @param priv A private context data from the caller
* *
* @return 0 if sucessful and negative error code on failure * @return 0 if sucessful and negative error code on failure
*/ */
static inline int sbi_platform_hart_start(const struct sbi_platform *plat, static inline int sbi_platform_hart_start(const struct sbi_platform *plat,
u32 hartid, ulong saddr, ulong priv) u32 hartid, ulong saddr)
{ {
if (plat && sbi_platform_ops(plat)->hart_start) if (plat && sbi_platform_ops(plat)->hart_start)
return sbi_platform_ops(plat)->hart_start(hartid, saddr, priv); return sbi_platform_ops(plat)->hart_start(hartid, saddr);
return SBI_ENOTSUPP; return SBI_ENOTSUPP;
} }

2
lib/sbi/sbi_hsm.c
View File

@@ -240,7 +240,7 @@ int sbi_hsm_hart_start(struct sbi_scratch *scratch, u32 hartid,
if (sbi_platform_has_hart_hotplug(plat) || if (sbi_platform_has_hart_hotplug(plat) ||
(sbi_platform_has_hart_secondary_boot(plat) && !init_count)) { (sbi_platform_has_hart_secondary_boot(plat) && !init_count)) {
return sbi_platform_hart_start(plat, hartid, return sbi_platform_hart_start(plat, hartid,
scratch->warmboot_addr, priv); scratch->warmboot_addr);
} else { } else {
sbi_platform_ipi_send(plat, hartid); sbi_platform_ipi_send(plat, hartid);
} }