Firmware/opensbi
8
0
Fork 0
forked from Mirrors/opensbi
Code Pull Requests Activity

lib: sbi_ipi: Move initial IPI clear to sbi_ipi_init()

Browse Source 
sbi_ipi_init() expects the platform warm init function to clear IPIs
on the local hart, but there is already a generic function to do this.
After this change, none of the existing drivers need a warm init
callback.

Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
This commit is contained in:
Samuel Holland
2024-10-25 11:59:47 -07:00
committed by Anup Patel
parent be9752a071
commit 693afc818f
13 changed files with 12 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/sbi/sbi_hsm.c
View File

@@ -178,7 +178,7 @@ static void sbi_hsm_hart_wait(struct sbi_scratch *scratch)
/*
* No need to clear IPI here because the sbi_ipi_init() will
* clear it for current HART via sbi_platform_ipi_init().
* clear it for current HART.
*/
}

8
lib/sbi/sbi_ipi.c
View File

@@ -332,14 +332,14 @@ int sbi_ipi_init(struct sbi_scratch *scratch, bool cold_boot)
ipi_data = sbi_scratch_offset_ptr(scratch, ipi_data_off);
ipi_data->ipi_type = 0x00;
/*
* Initialize platform IPI support. This will also clear any
* pending IPIs for current/calling HART.
*/
/* Initialize platform IPI support */
ret = sbi_platform_ipi_init(sbi_platform_ptr(scratch), cold_boot);
if (ret)
return ret;
/* Clear any pending IPIs for the current hart */
sbi_ipi_raw_clear();
/* Enable software interrupts */
csr_set(CSR_MIE, MIP_MSIP);