Firmware/opensbi
8
0
Fork 0
forked from Mirrors/opensbi
Code Pull Requests Activity

lib: Use bitwise & instead of boolean &&

Browse Source 
!(mipval && MIP_MSIP) simplifies to !mipval, which checks if the entire
variable is zero, not just a single bit. Fix this to use bitwise &
instead.

Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Atish Patra <atish.patra@wdc.com>
This commit is contained in:
Jacob Garber
2019-08-09 17:13:57 -06:00
committed by Anup Patel
parent 88c87f0af4
commit 3f738f5897
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/sbi/sbi_hart.c
View File

@@ -339,7 +339,7 @@ void sbi_hart_wait_for_coldboot(struct sbi_scratch *scratch, u32 hartid)
spin_lock(&coldboot_wait_bitmap_lock); spin_lock(&coldboot_wait_bitmap_lock);
coldboot_wait_bitmap &= ~(1UL << hartid); coldboot_wait_bitmap &= ~(1UL << hartid);
spin_unlock(&coldboot_wait_bitmap_lock); spin_unlock(&coldboot_wait_bitmap_lock);
} while (!(mipval && MIP_MSIP)); } while (!(mipval & MIP_MSIP));
csr_clear(CSR_MIP, MIP_MSIP); csr_clear(CSR_MIP, MIP_MSIP);
} }