Firmware/opensbi
8
0
Fork 0
forked from Mirrors/opensbi
Code Pull Requests Activity

include: sbi: Remove extid parameter from vendor_ext_provider() callback

Browse Source 
The extid parameter of vendor_ext_provider() is redundant so let us
remove it.

Signed-off-by: Anup Patel <apatel@ventanamicro.com>
This commit is contained in:
Anup Patel
2023-02-13 10:39:06 +05:30
committed by Anup Patel
parent 81adc62f45
commit 31b82e0d50
4 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
include/sbi/sbi_platform.h
View File

@@ -129,7 +129,7 @@ struct sbi_platform_operations {
/** Check if SBI vendor extension is implemented or not */ /** Check if SBI vendor extension is implemented or not */
bool (*vendor_ext_check)(void); bool (*vendor_ext_check)(void);
/** platform specific SBI extension implementation provider */ /** platform specific SBI extension implementation provider */
int (*vendor_ext_provider)(long extid, long funcid, int (*vendor_ext_provider)(long funcid,
const struct sbi_trap_regs *regs, const struct sbi_trap_regs *regs,
unsigned long *out_value, unsigned long *out_value,
struct sbi_trap_info *out_trap); struct sbi_trap_info *out_trap);
@@ -655,7 +655,6 @@ static inline bool sbi_platform_vendor_ext_check(
* Invoke platform specific vendor SBI extension implementation. * Invoke platform specific vendor SBI extension implementation.
* *
* @param plat pointer to struct sbi_platform * @param plat pointer to struct sbi_platform
* @param extid vendor SBI extension id
* @param funcid SBI function id within the extension id * @param funcid SBI function id within the extension id
* @param regs pointer to trap registers passed by the caller * @param regs pointer to trap registers passed by the caller
* @param out_value output value that can be filled by the callee * @param out_value output value that can be filled by the callee
@@ -665,14 +664,14 @@ static inline bool sbi_platform_vendor_ext_check(
*/ */
static inline int sbi_platform_vendor_ext_provider( static inline int sbi_platform_vendor_ext_provider(
const struct sbi_platform *plat, const struct sbi_platform *plat,
long extid, long funcid, long funcid,
const struct sbi_trap_regs *regs, const struct sbi_trap_regs *regs,
unsigned long *out_value, unsigned long *out_value,
struct sbi_trap_info *out_trap) struct sbi_trap_info *out_trap)
{ {
if (plat && sbi_platform_ops(plat)->vendor_ext_provider) { if (plat && sbi_platform_ops(plat)->vendor_ext_provider) {
return sbi_platform_ops(plat)->vendor_ext_provider(extid, return sbi_platform_ops(plat)->vendor_ext_provider(funcid,
funcid, regs, regs,
out_value, out_value,
out_trap); out_trap);
} }

2
lib/sbi/sbi_ecall_vendor.c
View File

@@ -43,7 +43,7 @@ static int sbi_ecall_vendor_handler(unsigned long extid, unsigned long funcid,
return SBI_ERR_NOT_SUPPORTED; return SBI_ERR_NOT_SUPPORTED;
return sbi_platform_vendor_ext_provider(sbi_platform_thishart_ptr(), return sbi_platform_vendor_ext_provider(sbi_platform_thishart_ptr(),
extid, funcid, regs, funcid, regs,
out_val, out_trap); out_val, out_trap);
} }

2
platform/generic/include/platform_override.h
View File

@@ -27,7 +27,7 @@ struct platform_override {
int (*extensions_init)(const struct fdt_match *match, int (*extensions_init)(const struct fdt_match *match,
struct sbi_hart_features *hfeatures); struct sbi_hart_features *hfeatures);
void (*fw_init)(void *fdt, const struct fdt_match *match); void (*fw_init)(void *fdt, const struct fdt_match *match);
int (*vendor_ext_provider)(long extid, long funcid, int (*vendor_ext_provider)(long funcid,
const struct sbi_trap_regs *regs, const struct sbi_trap_regs *regs,
unsigned long *out_value, unsigned long *out_value,
struct sbi_trap_info *out_trap, struct sbi_trap_info *out_trap,

4
platform/generic/platform.c
View File

@@ -186,12 +186,12 @@ static bool generic_vendor_ext_check(void)
true : false; true : false;
} }
static int generic_vendor_ext_provider(long extid, long funcid, static int generic_vendor_ext_provider(long funcid,
const struct sbi_trap_regs *regs, const struct sbi_trap_regs *regs,
unsigned long *out_value, unsigned long *out_value,
struct sbi_trap_info *out_trap) struct sbi_trap_info *out_trap)
{ {
return generic_plat->vendor_ext_provider(extid, funcid, regs, return generic_plat->vendor_ext_provider(funcid, regs,
out_value, out_trap, out_value, out_trap,
generic_plat_match); generic_plat_match);
} }