Firmware/opensbi
8
0
Fork 0
forked from Mirrors/opensbi
Code Pull Requests Activity

sbi: fwft: clear the config lock when warm boot

Browse Source 
The hotplug cpu should clear the fwft config's SBI_FWFT_SET_FLAG_LOCK
in the warm boot flow otherwise the cpu can't set the menvcfg.sse by
SBI_EXT_FWFT_SET sbi call and cause the illegal instruction when
accessing the CSR_SSP in kernel.

Signed-off-by: Nick Hu <nick.hu@sifive.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
This commit is contained in:
Nick Hu
2024-11-15 15:33:08 +08:00
committed by Anup Patel
parent 111772353f
commit 23ef9c5f00
1 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
lib/sbi/sbi_fwft.c
View File

@@ -311,6 +311,18 @@ static int fwft_get_feature(enum sbi_fwft_feature_t feature,
return SBI_SUCCESS; return SBI_SUCCESS;
} }
static void fwft_clear_config_lock(enum sbi_fwft_feature_t feature)
{
int ret;
struct fwft_config *conf;
ret = fwft_get_feature(feature, &conf);
if (ret)
return;
conf->flags &= ~SBI_FWFT_SET_FLAG_LOCK;
}
int sbi_fwft_set(enum sbi_fwft_feature_t feature, unsigned long value, int sbi_fwft_set(enum sbi_fwft_feature_t feature, unsigned long value,
unsigned long flags) unsigned long flags)
{ {
@@ -414,5 +426,8 @@ int sbi_fwft_init(struct sbi_scratch *scratch, bool cold_boot)
fwft_set_hart_state_ptr(scratch, fhs); fwft_set_hart_state_ptr(scratch, fhs);
} }
for (i = 0; i < array_size(features); i++)
fwft_clear_config_lock(features[i].id);
return 0; return 0;
} }