Firmware/opensbi
8
0
Fork 0
forked from Mirrors/opensbi
Code Pull Requests Activity

include: sbi: Don't pack struct sbi_platform and sbi_platform_operations

Browse Source 
We don't need to pack struct sbi_platform and sbi_platform_operations
because GCC ensures member offsets match member data type irrespective
to the target system (RV32 or RV64). This also allows GCC to generate
more optimized instruction sequence when accessing members of struct
sbi_platform and struct sbi_platform_operations.

Reported-by: Paul Campbell <taniwha@gmail.com>
Signed-off-by: Anup Patel <anup.patel@wdc.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Atish Patra <atish.patra@wdc.com>
This commit is contained in:
Anup Patel
2021-01-11 17:15:00 +05:30
committed by Anup Patel
parent 386eba21bf
commit 1bbf36183e
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
include/sbi/sbi_platform.h
View File

@@ -152,7 +152,7 @@ struct sbi_platform_operations {
const struct sbi_trap_regs *regs, const struct sbi_trap_regs *regs,
unsigned long *out_value, unsigned long *out_value,
struct sbi_trap_info *out_trap); struct sbi_trap_info *out_trap);
} __packed; };
/** Platform default per-HART stack size for exception/interrupt handling */ /** Platform default per-HART stack size for exception/interrupt handling */
#define SBI_PLATFORM_DEFAULT_HART_STACK_SIZE 8192 #define SBI_PLATFORM_DEFAULT_HART_STACK_SIZE 8192
@@ -199,7 +199,7 @@ struct sbi_platform {
* 2. HART id < SBI_HARTMASK_MAX_BITS * 2. HART id < SBI_HARTMASK_MAX_BITS
*/ */
const u32 *hart_index2id; const u32 *hart_index2id;
} __packed; };
/** Get pointer to sbi_platform for sbi_scratch pointer */ /** Get pointer to sbi_platform for sbi_scratch pointer */
#define sbi_platform_ptr(__s) \ #define sbi_platform_ptr(__s) \