Firmware/opensbi
8
0
Fork 0
forked from Mirrors/opensbi
Code Pull Requests Activity

lib: sbi: Remove unnecessary SBI_INIT_LIST_HEAD

Browse Source 
No need to initialise the nodes to be added to the linked list

Signed-off-by: Xiang W <wxjstz@126.com>
Reviewed-by: Samuel Holland <samuel.holland@sifive.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
Link: https://lore.kernel.org/r/20250319123944.505756-1-wxjstz@126.com
Signed-off-by: Anup Patel <anup@brainfault.org>
This commit is contained in:
Xiang W
2025-03-19 20:39:38 +08:00
committed by Anup Patel
parent 169b4b8ae2
commit 190979b4fc
5 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
lib/sbi/sbi_ecall.c
View File

@@ -93,7 +93,6 @@ int sbi_ecall_register_extension(struct sbi_ecall_extension *ext)
return SBI_EINVAL; return SBI_EINVAL;
} }
SBI_INIT_LIST_HEAD(&ext->head);
sbi_list_add_tail(&ext->head, &ecall_exts_list); sbi_list_add_tail(&ext->head, &ecall_exts_list);
return 0; return 0;

1
lib/sbi/sbi_heap.c
View File

@@ -244,7 +244,6 @@ int sbi_heap_init_new(struct sbi_heap_control *hpctrl, unsigned long base,
/* Prepare free node list */ /* Prepare free node list */
for (i = 0; i < (hpctrl->hksize / sizeof(*n)); i++) { for (i = 0; i < (hpctrl->hksize / sizeof(*n)); i++) {
n = (struct heap_node *)(hpctrl->hkbase + (sizeof(*n) * i)); n = (struct heap_node *)(hpctrl->hkbase + (sizeof(*n) * i));
SBI_INIT_LIST_HEAD(&n->head);
n->addr = n->size = 0; n->addr = n->size = 0;
sbi_list_add_tail(&n->head, &hpctrl->free_node_list); sbi_list_add_tail(&n->head, &hpctrl->free_node_list);
} }

1
lib/sbi/sbi_mpxy.c
View File

@@ -228,7 +228,6 @@ int sbi_mpxy_register_channel(struct sbi_mpxy_channel *channel)
mpxy_shmem_size = (mpxy_shmem_size + (PAGE_SIZE - 1)) / PAGE_SIZE; mpxy_shmem_size = (mpxy_shmem_size + (PAGE_SIZE - 1)) / PAGE_SIZE;
} }
SBI_INIT_LIST_HEAD(&channel->head);
sbi_list_add_tail(&channel->head, &mpxy_channel_list); sbi_list_add_tail(&channel->head, &mpxy_channel_list);
return SBI_OK; return SBI_OK;

1
lib/utils/fdt/fdt_fixup.c
View File

@@ -415,7 +415,6 @@ int fdt_register_general_fixup(struct fdt_general_fixup *fixup)
return SBI_EALREADY; return SBI_EALREADY;
} }
SBI_INIT_LIST_HEAD(&fixup->head);
sbi_list_add_tail(&fixup->head, &fixup_list); sbi_list_add_tail(&fixup->head, &fixup_list);
return 0; return 0;

2
lib/utils/mailbox/mailbox.c
View File

@@ -34,7 +34,6 @@ int mbox_controller_add(struct mbox_controller *mbox)
if (mbox_controller_find(mbox->id)) if (mbox_controller_find(mbox->id))
return SBI_EALREADY; return SBI_EALREADY;
SBI_INIT_LIST_HEAD(&mbox->node);
ATOMIC_INIT(&mbox->xfer_next_seq, 0); ATOMIC_INIT(&mbox->xfer_next_seq, 0);
SBI_INIT_LIST_HEAD(&mbox->chan_list); SBI_INIT_LIST_HEAD(&mbox->chan_list);
sbi_list_add(&mbox->node, &mbox_list); sbi_list_add(&mbox->node, &mbox_list);
@@ -80,7 +79,6 @@ struct mbox_chan *mbox_controller_request_chan(struct mbox_controller *mbox,
if (!ret) if (!ret)
return NULL; return NULL;
SBI_INIT_LIST_HEAD(&ret->node);
ret->mbox = mbox; ret->mbox = mbox;
sbi_memcpy(ret->chan_args, chan_args, sizeof(ret->chan_args)); sbi_memcpy(ret->chan_args, chan_args, sizeof(ret->chan_args));
sbi_list_add(&ret->node, &mbox->chan_list); sbi_list_add(&ret->node, &mbox->chan_list);