Firmware/opensbi
8
0
Fork 0
forked from Mirrors/opensbi
Code Pull Requests Activity

docs: Remove github PR as an option

Browse Source 
OpenSBI development workflow is mailing list based from the
beginning. Initially, github PRs were added as an option but it turned
out that it is not feasible to support both github PR and mailing list
based workflows. Hence, all the PRs has been redirected to use the
mailing list from a long time. In fact, it is source of confusion to
have both options.

Update the documentation to reflect the reality.

Signed-off-by: Atish Patra <atishp@rivosinc.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
This commit is contained in:
Atish Patra
2024-08-29 18:03:55 -07:00
committed by Anup Patel
parent 1cb234b1c9
commit 00093a2000
1 changed files with 6 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
docs/contributing.md
View File

@@ -1,17 +1,15 @@
OpenSBI Contribution Guideline OpenSBI Contribution Guideline
============================== ==============================
All contributions to OpenSBI can be sent in the following ways: All contributions to OpenSBI must be sent via email patches to the OpenSBI
1. Email patches to the OpenSBI mailing list at `opensbi@lists.infradead.org` mailing list at `opensbi@lists.infradead.org`
2. GitHub Pull Requests (PRs) to the [OpenSBI main repository]
To join the OpenSBI mailing list, please visit the [OpenSBI infradead page]. To join the OpenSBI mailing list, please visit the [OpenSBI infradead page].
The OpenSBI maintainers prefer patches via the OpenSBI mailing list The mailing list based patch approach is preferred over github PRs so that they
(option 1 above) so that they are visible to a wider audience. All are visible to a wider audience. All accepted patches on the OpenSBI mailing
accepted patches on the OpenSBI mailing list will be taken by any of list will be taken by one of the OpenSBI maintainers and merged into the
the OpenSBI maintainers and merged into the [OpenSBI main repository] [OpenSBI main repository].
using GitHub PRs.
All contributed work must follow the following rules: All contributed work must follow the following rules:
1. OpenSBI code should be written in accordance to the [Linux coding style]. 1. OpenSBI code should be written in accordance to the [Linux coding style].
@@ -33,9 +31,6 @@ riscv/opensbi repository. Instead, prefer using a fork of the riscv/opensbi main
repository and branches within that fork to create pull requests. repository and branches within that fork to create pull requests.
7. A maintainer cannot merge his own pull requests in the riscv/opensbi main 7. A maintainer cannot merge his own pull requests in the riscv/opensbi main
repository. repository.
8. A pull request must get at least one review from a maintainer.
9. A pull request must spend at least 24 hours in review to allow for other
developers to review.
----------------------------------------------------------------------- -----------------------------------------------------------------------