mirror of
https://github.com/riscv-software-src/opensbi.git
synced 2025-08-24 15:31:22 +01:00
057eb10b6d
Currently, we see following compile error in the designeware GPIO driver
for RV32 systems:
lib/utils/gpio/fdt_gpio_designware.c:115:20: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
115 | chip->dr = (void *)addr + (bank * 0xc);
| ^
lib/utils/gpio/fdt_gpio_designware.c:116:21: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
116 | chip->ext = (void *)addr + (bank * 4) + 0x50;
We fix the above error using an explicit type-cast to 'unsigned long'.
Fixes: 7828eebaaa ("gpio/desginware: add Synopsys DesignWare APB GPIO support")
Signed-off-by: Anup Patel <apatel@ventanamicro.com>
Reviewed-by: Xiang W <wxjstz@126.com>
141 lines
3.3 KiB
C
141 lines
3.3 KiB
C
/*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*
|
|
* Copyright (c) 2022 SiFive
|
|
*
|
|
* GPIO driver for Synopsys DesignWare APB GPIO
|
|
*
|
|
* Authors:
|
|
* Ben Dooks <ben.dooks@sifive.com>
|
|
*/
|
|
|
|
#include <libfdt.h>
|
|
|
|
#include <sbi/riscv_io.h>
|
|
#include <sbi/sbi_error.h>
|
|
|
|
#include <sbi_utils/fdt/fdt_helper.h>
|
|
#include <sbi_utils/gpio/fdt_gpio.h>
|
|
|
|
#define DW_GPIO_CHIP_MAX 4 /* need 1 per bank in use */
|
|
#define DW_GPIO_PINS_MAX 32
|
|
|
|
#define DW_GPIO_DDR 0x4
|
|
#define DW_GPIO_DR 0x0
|
|
#define DW_GPIO_BIT(_b) (1UL << (_b))
|
|
|
|
struct dw_gpio_chip {
|
|
void *dr;
|
|
void *ext;
|
|
struct gpio_chip chip;
|
|
};
|
|
|
|
extern struct fdt_gpio fdt_gpio_designware;
|
|
|
|
static unsigned int dw_gpio_chip_count;
|
|
static struct dw_gpio_chip dw_gpio_chip_array[DW_GPIO_CHIP_MAX];
|
|
|
|
#define pin_to_chip(__p) container_of((__p)->chip, struct dw_gpio_chip, chip);
|
|
|
|
static int dw_gpio_direction_output(struct gpio_pin *gp, int value)
|
|
{
|
|
struct dw_gpio_chip *chip = pin_to_chip(gp);
|
|
unsigned long v;
|
|
|
|
v = readl(chip->dr + DW_GPIO_DR);
|
|
if (!value)
|
|
v &= ~DW_GPIO_BIT(gp->offset);
|
|
else
|
|
v |= DW_GPIO_BIT(gp->offset);
|
|
writel(v, chip->dr + DW_GPIO_DR);
|
|
|
|
/* the DR is output only so we can set it then the DDR to set
|
|
* the data direction, to avoid glitches.
|
|
*/
|
|
v = readl(chip->dr + DW_GPIO_DDR);
|
|
v |= DW_GPIO_BIT(gp->offset);
|
|
writel(v, chip->dr + DW_GPIO_DDR);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void dw_gpio_set(struct gpio_pin *gp, int value)
|
|
{
|
|
struct dw_gpio_chip *chip = pin_to_chip(gp);
|
|
unsigned long v;
|
|
|
|
v = readl(chip->dr + DW_GPIO_DR);
|
|
if (!value)
|
|
v &= ~DW_GPIO_BIT(gp->offset);
|
|
else
|
|
v |= DW_GPIO_BIT(gp->offset);
|
|
writel(v, chip->dr + DW_GPIO_DR);
|
|
}
|
|
|
|
/* notes:
|
|
* each sub node is a bank and has ngpios or snpns,nr-gpios and a reg property
|
|
* with the compatible `snps,dw-apb-gpio-port`.
|
|
* bank A is the only one with irq support but we're not using it here
|
|
*/
|
|
|
|
static int dw_gpio_init_bank(void *fdt, int nodeoff, u32 phandle,
|
|
const struct fdt_match *match)
|
|
{
|
|
struct dw_gpio_chip *chip;
|
|
const fdt32_t *val;
|
|
uint64_t addr;
|
|
int rc, poff, nr_pins, bank, len;
|
|
|
|
if (dw_gpio_chip_count >= DW_GPIO_CHIP_MAX)
|
|
return SBI_ENOSPC;
|
|
|
|
/* need to get parent for the address property */
|
|
poff = fdt_parent_offset(fdt, nodeoff);
|
|
if (poff < 0)
|
|
return SBI_EINVAL;
|
|
|
|
rc = fdt_get_node_addr_size(fdt, poff, 0, &addr, NULL);
|
|
if (rc)
|
|
return rc;
|
|
|
|
val = fdt_getprop(fdt, nodeoff, "reg", &len);
|
|
if (!val || len <= 0)
|
|
return SBI_EINVAL;
|
|
bank = fdt32_to_cpu(*val);
|
|
|
|
val = fdt_getprop(fdt, nodeoff, "snps,nr-gpios", &len);
|
|
if (!val)
|
|
val = fdt_getprop(fdt, nodeoff, "ngpios", &len);
|
|
if (!val || len <= 0)
|
|
return SBI_EINVAL;
|
|
nr_pins = fdt32_to_cpu(*val);
|
|
|
|
chip = &dw_gpio_chip_array[dw_gpio_chip_count];
|
|
|
|
chip->dr = (void *)(uintptr_t)addr + (bank * 0xc);
|
|
chip->ext = (void *)(uintptr_t)addr + (bank * 4) + 0x50;
|
|
chip->chip.driver = &fdt_gpio_designware;
|
|
chip->chip.id = phandle;
|
|
chip->chip.ngpio = nr_pins;
|
|
chip->chip.set = dw_gpio_set;
|
|
chip->chip.direction_output = dw_gpio_direction_output;
|
|
rc = gpio_chip_add(&chip->chip);
|
|
if (rc)
|
|
return rc;
|
|
|
|
dw_gpio_chip_count++;
|
|
return 0;
|
|
}
|
|
|
|
/* since we're only probed when used, match on port not main controller node */
|
|
static const struct fdt_match dw_gpio_match[] = {
|
|
{ .compatible = "snps,dw-apb-gpio-port" },
|
|
{ },
|
|
};
|
|
|
|
struct fdt_gpio fdt_gpio_designware = {
|
|
.match_table = dw_gpio_match,
|
|
.xlate = fdt_gpio_simple_xlate,
|
|
.init = dw_gpio_init_bank,
|
|
};
|