Mirrors/opensbi
4
0
Fork 1
mirror of https://github.com/riscv-software-src/opensbi.git synced 2026-01-03 02:51:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

lib: sbi_pmu: Fix multiple start and stop operations of FW counters

Browse Source 
Currently, OpenSBI returns SBI_ERR_ALREADY_STARTED when attempting to
start a HW counter that is already started and SBI_ERR_ALREADY_STOPPED
when attempting to stop a HW counter that is already stopped. However,
this is not yet implemented for FW counters.

Add the necessary checks to return the same error codes when attempting
the same actions on FW counters.

Signed-off-by: James Raphael Tiovalen <jamestiotio@gmail.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
Link: https://lore.kernel.org/r/20251213104146.422972-1-jamestiotio@gmail.com
Signed-off-by: Anup Patel <anup@brainfault.org>
This commit is contained in:
James Raphael Tiovalen
2025-12-13 18:41:46 +08:00
committed by Anup Patel
parent 19f0c83512
commit f7b81034aa
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/sbi/sbi_pmu.c
View File

@@ -453,6 +453,9 @@ static int pmu_ctr_start_fw(struct sbi_pmu_hart_state *phs,
event_code > SBI_PMU_FW_PLATFORM) event_code > SBI_PMU_FW_PLATFORM)
return SBI_EINVAL; return SBI_EINVAL;
if (phs->fw_counters_started & BIT(cidx - num_hw_ctrs))
return SBI_EALREADY_STARTED;
if (SBI_PMU_FW_PLATFORM == event_code) { if (SBI_PMU_FW_PLATFORM == event_code) {
if (!pmu_dev || if (!pmu_dev ||
!pmu_dev->fw_counter_write_value || !pmu_dev->fw_counter_write_value ||
@@ -623,6 +626,9 @@ static int pmu_ctr_stop_fw(struct sbi_pmu_hart_state *phs,
event_code > SBI_PMU_FW_PLATFORM) event_code > SBI_PMU_FW_PLATFORM)
return SBI_EINVAL; return SBI_EINVAL;
if (!(phs->fw_counters_started & BIT(cidx - num_hw_ctrs)))
return SBI_EALREADY_STOPPED;
if (SBI_PMU_FW_PLATFORM == event_code && if (SBI_PMU_FW_PLATFORM == event_code &&
pmu_dev && pmu_dev->fw_counter_stop) { pmu_dev && pmu_dev->fw_counter_stop) {
ret = pmu_dev->fw_counter_stop(phs->hartid, cidx - num_hw_ctrs); ret = pmu_dev->fw_counter_stop(phs->hartid, cidx - num_hw_ctrs);