Mirrors/opensbi
1
0
Fork 1
mirror of https://github.com/riscv-software-src/opensbi.git synced 2025-08-24 15:31:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

lib: sbi: Allow relaxed MMIO writes in device ipi_send() callback

Browse Source 
Currently, we have a smp_wmb() between atomic_raw_set_bit() and
ipi_send() device callback whereas the MMIO writes done by the
device ipi_send() callback will also include a barrier.

We can avoid unnecessary/redundant barriers described above by
allowing relaxed MMIO writes in device ipi_send() callback. To
achieve this, we simply use  wmb() instead of smp_wmb() before
calling device ipi_send().

Signed-off-by: Anup Patel <apatel@ventanamicro.com>
Reported-by: Bo Gan <ganboing@gmail.com>
This commit is contained in:
Anup Patel
2023-11-21 14:49:42 +05:30
committed by Anup Patel
parent 791704cd09
commit f520256d03
3 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
lib/sbi/sbi_ipi.c
View File

@@ -67,14 +67,12 @@ static int sbi_ipi_send(struct sbi_scratch *scratch, u32 remote_hartindex,
* trigger the interrupt * trigger the interrupt
*/ */
atomic_raw_set_bit(event, &ipi_data->ipi_type); atomic_raw_set_bit(event, &ipi_data->ipi_type);
smp_wmb();
if (ipi_dev && ipi_dev->ipi_send) ret = sbi_ipi_raw_send(remote_hartindex);
ipi_dev->ipi_send(remote_hartindex);
sbi_pmu_ctr_incr_fw(SBI_PMU_FW_IPI_SENT); sbi_pmu_ctr_incr_fw(SBI_PMU_FW_IPI_SENT);
return 0; return ret;
} }
static int sbi_ipi_sync(struct sbi_scratch *scratch, u32 event) static int sbi_ipi_sync(struct sbi_scratch *scratch, u32 event)
@@ -243,6 +241,15 @@ int sbi_ipi_raw_send(u32 hartindex)
if (!ipi_dev || !ipi_dev->ipi_send) if (!ipi_dev || !ipi_dev->ipi_send)
return SBI_EINVAL; return SBI_EINVAL;
/*
* Ensure that memory or MMIO writes done before
* this function are not observed after the memory
* or MMIO writes done by the ipi_send() device
* callback. This also allows the ipi_send() device
* callback to use relaxed MMIO writes.
*/
wmb();
ipi_dev->ipi_send(hartindex); ipi_dev->ipi_send(hartindex);
return 0; return 0;
} }

2
lib/utils/ipi/aclint_mswi.c
View File

@@ -41,7 +41,7 @@ static void mswi_ipi_send(u32 hart_index)
/* Set ACLINT IPI */ /* Set ACLINT IPI */
msip = (void *)mswi->addr; msip = (void *)mswi->addr;
writel(1, &msip[sbi_hartindex_to_hartid(hart_index) - writel_relaxed(1, &msip[sbi_hartindex_to_hartid(hart_index) -
mswi->first_hartid]); mswi->first_hartid]);
} }

4
lib/utils/irqchip/imsic.c
View File

@@ -186,8 +186,8 @@ static void imsic_ipi_send(u32 hart_index)
} }
if (regs->size && (reloff < regs->size)) if (regs->size && (reloff < regs->size))
writel(IMSIC_IPI_ID, writel_relaxed(IMSIC_IPI_ID,
(void *)(regs->addr + reloff + IMSIC_MMIO_PAGE_LE)); (void *)(regs->addr + reloff + IMSIC_MMIO_PAGE_LE));
} }
static struct sbi_ipi_device imsic_ipi_device = { static struct sbi_ipi_device imsic_ipi_device = {