Mirrors/opensbi
3
0
Fork 1
mirror of https://github.com/riscv-software-src/opensbi.git synced 2026-09-20 15:21:42 +01:00
Code Issues Packages Projects Releases Wiki Activity

lib: sbi_heap: add TSA annotations

Browse Source 
Add Thread Safety Analysis (TSA) annotations for the heap allocator.
This includes indicating which fields are protected by a spinlock and
annotating functions that must be called under a spinlock. Exclude
sbi_heap_init_new(), as the spinlock cannot be acquired before it is
initialized.

Signed-off-by: Carlos López <carlos.lopezr4096@gmail.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
Link: https://lore.kernel.org/r/20260909162322.29778-6-carlos.lopezr4096@gmail.com
Signed-off-by: Anup Patel <anup@brainfault.org>
This commit is contained in:
Carlos López
2026-09-16 09:48:30 +05:30
committed by Anup Patel
parent 832ede6a8f
commit eaac726ea1
1 changed files with 14 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/sbi/sbi_heap.c
+14 -11
View File
@@ -28,18 +28,18 @@ struct heap_node {
struct sbi_heap_control { struct sbi_heap_control {
spinlock_t lock; spinlock_t lock;
unsigned long base; unsigned long base GUARDED_BY(&lock);
unsigned long size; unsigned long size GUARDED_BY(&lock);
unsigned long resv; unsigned long resv GUARDED_BY(&lock);
struct sbi_dlist free_node_list; struct sbi_dlist free_node_list GUARDED_BY(&lock);
struct sbi_dlist free_space_list; struct sbi_dlist free_space_list GUARDED_BY(&lock);
struct sbi_dlist used_space_list; struct sbi_dlist used_space_list GUARDED_BY(&lock);
struct heap_node init_free_space_node; struct heap_node init_free_space_node GUARDED_BY(&lock);
}; };
struct sbi_heap_control global_hpctrl; struct sbi_heap_control global_hpctrl;
static bool alloc_nodes(struct sbi_heap_control *hpctrl) static bool alloc_nodes(struct sbi_heap_control *hpctrl) MUST_HOLD(&hpctrl->lock)
{ {
size_t size = HEAP_NODE_BATCH_SIZE * sizeof(struct heap_node); size_t size = HEAP_NODE_BATCH_SIZE * sizeof(struct heap_node);
struct heap_node *n, *new = NULL; struct heap_node *n, *new = NULL;
@@ -69,8 +69,9 @@ static bool alloc_nodes(struct sbi_heap_control *hpctrl)
return true; return true;
} }
static void *alloc_with_align(struct sbi_heap_control *hpctrl, static void *alloc_with_align(struct sbi_heap_control *hpctrl, size_t align,
size_t align, size_t size) size_t size)
MUST_NOT_HOLD(&hpctrl->lock)
{ {
void *ret = NULL; void *ret = NULL;
struct heap_node *n, *np; struct heap_node *n, *np;
@@ -230,17 +231,19 @@ unsigned long sbi_heap_free_space_from(struct sbi_heap_control *hpctrl)
} }
unsigned long sbi_heap_used_space_from(struct sbi_heap_control *hpctrl) unsigned long sbi_heap_used_space_from(struct sbi_heap_control *hpctrl)
NO_THREAD_SAFETY_ANALYSIS
{ {
return hpctrl->size - hpctrl->resv - sbi_heap_free_space(); return hpctrl->size - hpctrl->resv - sbi_heap_free_space();
} }
unsigned long sbi_heap_reserved_space_from(struct sbi_heap_control *hpctrl) unsigned long sbi_heap_reserved_space_from(struct sbi_heap_control *hpctrl)
NO_THREAD_SAFETY_ANALYSIS
{ {
return hpctrl->resv; return hpctrl->resv;
} }
int sbi_heap_init_new(struct sbi_heap_control *hpctrl, unsigned long base, int sbi_heap_init_new(struct sbi_heap_control *hpctrl, unsigned long base,
unsigned long size) unsigned long size) NO_THREAD_SAFETY_ANALYSIS
{ {
struct heap_node *n; struct heap_node *n;