mirror of
https://github.com/riscv-software-src/opensbi.git
synced 2025-08-25 15:51:41 +01:00
include: sbi_platform: fix compilation for GCC-9
GCC-9 will throw a warning when using the %s format specifier with a possible NULL parameter and since -Werror is used, the compilation breaks for GCC-9. In function 'sbi_boot_prints', inlined from 'init_coldboot' at <redacted>/opensbi/lib/sbi/sbi_init.c:107:3, inlined from 'sbi_init' at <redacted>/opensbi/lib/sbi/sbi_init.c:189:3: <redacted>/opensbi/lib/sbi/sbi_init.c:56:2: error: '%s' directive argument is null [-Werror=format-overflow=] 56 | sbi_printf("Platform Name : %s\n", sbi_platform_name(plat)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors This is one way to fix this, currently there is nothing in the tree checking for `sbi_platfrom_name() == NULL` so we can just return "Unknown" instead of NULL on failure. Signed-off-by: Martin Pietryka <martin@pietryka.at> Reviewed-by: Anup Patel <anup.patel@wdc.com> Tested-by: David Abdurachmanov <david.abdurachmanov@sifive.com>
This commit is contained in:

committed by
Anup Patel

parent
813f7f4c25
commit
dc40042322
@@ -200,13 +200,13 @@ struct sbi_platform {
|
|||||||
*
|
*
|
||||||
* @param plat pointer to struct sbi_platform
|
* @param plat pointer to struct sbi_platform
|
||||||
*
|
*
|
||||||
* @return pointer to platform name on success and NULL on failure
|
* @return pointer to platform name on success and "Unknown" on failure
|
||||||
*/
|
*/
|
||||||
static inline const char *sbi_platform_name(const struct sbi_platform *plat)
|
static inline const char *sbi_platform_name(const struct sbi_platform *plat)
|
||||||
{
|
{
|
||||||
if (plat)
|
if (plat)
|
||||||
return plat->name;
|
return plat->name;
|
||||||
return NULL;
|
return "Unknown";
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
Reference in New Issue
Block a user