lib: sbi: Simplify ipi platform operations

Instead of having ipi_send() and ipi_clear() callbacks in
platform operations, it will be much simpler for ipi driver
to directly register these operations as a device to sbi_ipi
implementation.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
This commit is contained in:
Anup Patel
2021-04-22 10:27:15 +05:30
committed by Anup Patel
parent 559a8f1d3b
commit dc39c7b630
18 changed files with 72 additions and 109 deletions

View File

@@ -12,6 +12,7 @@
#include <sbi/riscv_encoding.h>
#include <sbi/sbi_console.h>
#include <sbi/sbi_const.h>
#include <sbi/sbi_ipi.h>
#include <sbi/sbi_platform.h>
#include <sbi/sbi_trap.h>
#include <sbi_utils/fdt/fdt_fixup.h>
@@ -85,6 +86,12 @@ static int ae350_irqchip_init(bool cold_boot)
return plic_warm_irqchip_init(&plic, 2 * hartid, 2 * hartid + 1);
}
static struct sbi_ipi_device plicsw_ipi = {
.name = "ae350_plicsw",
.ipi_send = plicsw_ipi_send,
.ipi_clear = plicsw_ipi_clear
};
/* Initialize IPI for current HART. */
static int ae350_ipi_init(bool cold_boot)
{
@@ -95,6 +102,8 @@ static int ae350_ipi_init(bool cold_boot)
AE350_HART_COUNT);
if (ret)
return ret;
sbi_ipi_set_device(&plicsw_ipi);
}
return plicsw_warm_ipi_init();
@@ -168,8 +177,6 @@ const struct sbi_platform_operations platform_ops = {
.irqchip_init = ae350_irqchip_init,
.ipi_init = ae350_ipi_init,
.ipi_send = plicsw_ipi_send,
.ipi_clear = plicsw_ipi_clear,
.timer_init = ae350_timer_init,

View File

@@ -156,8 +156,6 @@ const struct sbi_platform_operations platform_ops = {
.console_init = ariane_console_init,
.irqchip_init = ariane_irqchip_init,
.ipi_init = ariane_ipi_init,
.ipi_send = clint_ipi_send,
.ipi_clear = clint_ipi_clear,
.timer_init = ariane_timer_init,
};

View File

@@ -182,8 +182,6 @@ const struct sbi_platform_operations platform_ops = {
.console_init = openpiton_console_init,
.irqchip_init = openpiton_irqchip_init,
.ipi_init = openpiton_ipi_init,
.ipi_send = clint_ipi_send,
.ipi_clear = clint_ipi_clear,
.timer_init = openpiton_timer_init,
};

View File

@@ -213,8 +213,6 @@ const struct sbi_platform_operations platform_ops = {
.console_init = fdt_serial_init,
.irqchip_init = fdt_irqchip_init,
.irqchip_exit = fdt_irqchip_exit,
.ipi_send = fdt_ipi_send,
.ipi_clear = fdt_ipi_clear,
.ipi_init = fdt_ipi_init,
.ipi_exit = fdt_ipi_exit,
.get_tlbr_flush_limit = generic_tlbr_flush_limit,

View File

@@ -153,8 +153,6 @@ const struct sbi_platform_operations platform_ops = {
.irqchip_init = k210_irqchip_init,
.ipi_init = k210_ipi_init,
.ipi_send = clint_ipi_send,
.ipi_clear = clint_ipi_clear,
.system_reset_check = k210_system_reset_check,
.system_reset = k210_system_reset,

View File

@@ -204,8 +204,6 @@ const struct sbi_platform_operations platform_ops = {
.final_init = ux600_final_init,
.console_init = ux600_console_init,
.irqchip_init = ux600_irqchip_init,
.ipi_send = clint_ipi_send,
.ipi_clear = clint_ipi_clear,
.ipi_init = ux600_ipi_init,
.timer_init = ux600_timer_init,
.system_reset_check = ux600_system_reset_check,

View File

@@ -158,8 +158,6 @@ const struct sbi_platform_operations platform_ops = {
.final_init = fu540_final_init,
.console_init = fu540_console_init,
.irqchip_init = fu540_irqchip_init,
.ipi_send = clint_ipi_send,
.ipi_clear = clint_ipi_clear,
.ipi_init = fu540_ipi_init,
.get_tlbr_flush_limit = fu540_get_tlbr_flush_limit,
.timer_init = fu540_timer_init,

View File

@@ -98,24 +98,6 @@ static int platform_ipi_init(bool cold_boot)
return clint_warm_ipi_init();
}
/*
* Send IPI to a target HART
*/
static void platform_ipi_send(u32 target_hart)
{
/* Example if the generic CLINT driver is used */
clint_ipi_send(target_hart);
}
/*
* Clear IPI for a target HART.
*/
static void platform_ipi_clear(u32 target_hart)
{
/* Example if the generic CLINT driver is used */
clint_ipi_clear(target_hart);
}
/*
* Initialize platform timer for current HART.
*/
@@ -156,8 +138,6 @@ const struct sbi_platform_operations platform_ops = {
.final_init = platform_final_init,
.console_init = platform_console_init,
.irqchip_init = platform_irqchip_init,
.ipi_send = platform_ipi_send,
.ipi_clear = platform_ipi_clear,
.ipi_init = platform_ipi_init,
.timer_init = platform_timer_init,
.system_reset_check = platform_system_reset_check,