Mirrors/opensbi
3
0
Fork 1
mirror of https://github.com/riscv-software-src/opensbi.git synced 2026-05-23 14:21:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

lib: utils/regmap: Fix reg_stride calculation in syscon regmap

Browse Source 
The reg_stride field represents the address stride in bytes between
consecutive registers. The Linux kernel regmap framework validates
register accesses using IS_ALIGNED(reg, map->reg_stride) as an address
alignment check (drivers/base/regmap/regmap.c). The Linux kernel syscon
driver (drivers/mfd/syscon.c) sets reg_stride directly to reg_io_width:

  syscon_config.reg_stride = reg_io_width;

The current OpenSBI code incorrectly multiplies reg_io_width by 8,
converting a byte value to bits. Fix this by using reg_io_width directly
as the stride value, consistent with the Linux kernel.

Fixes: f21d8f7d59 ("lib: utils/regmap: Add simple FDT based syscon regmap driver")
Signed-off-by: David E. Garcia Porras <david.garcia@aheadcomputing.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
Link: https://lore.kernel.org/r/20260403202903.3407945-1-david.garcia@aheadcomputing.com
Signed-off-by: Anup Patel <anup@brainfault.org>
This commit is contained in:
David E. Garcia Porras
2026-04-03 14:29:03 -06:00
committed by Anup Patel
parent 65bb705f7b
commit 8536a351fd
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/utils/regmap/fdt_regmap_syscon.c
+1 -1
View File
@@ -190,7 +190,7 @@ static int regmap_syscon_init(const void *fdt, int nodeoff,
srm->rmap.id = nodeoff; srm->rmap.id = nodeoff;
srm->rmap.reg_shift = 0; srm->rmap.reg_shift = 0;
srm->rmap.reg_stride = srm->reg_io_width * 8; srm->rmap.reg_stride = srm->reg_io_width;
srm->rmap.reg_base = 0; srm->rmap.reg_base = 0;
srm->rmap.reg_max = size / srm->reg_io_width; srm->rmap.reg_max = size / srm->reg_io_width;
switch (srm->reg_io_width) { switch (srm->reg_io_width) {