From ca864a978d923dc44236e977b797d470c3ee2c00 Mon Sep 17 00:00:00 2001 From: Anup Patel Date: Wed, 24 Feb 2021 15:26:44 +0530 Subject: [PATCH] lib: sbi: Fix error codes returned by HSM start() and stop() functions The sbi_hsm_hart_start() and sbi_hsm_hart_stop() functions should only return error codes as defined by the SBI specification. Signed-off-by: Anup Patel Reviewed-by: Atish Patra --- lib/sbi/sbi_hsm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/sbi/sbi_hsm.c b/lib/sbi/sbi_hsm.c index 10099c2a..63fa8c21 100644 --- a/lib/sbi/sbi_hsm.c +++ b/lib/sbi/sbi_hsm.c @@ -202,7 +202,7 @@ int sbi_hsm_hart_start(struct sbi_scratch *scratch, return SBI_EINVAL; if (dom && !sbi_domain_check_addr(dom, saddr, smode, SBI_DOMAIN_EXECUTE)) - return SBI_EINVAL; + return SBI_EINVALID_ADDR; rscratch = sbi_hartid_to_scratch(hartid); if (!rscratch) @@ -251,7 +251,7 @@ int sbi_hsm_hart_stop(struct sbi_scratch *scratch, bool exitnow) if (oldstate != SBI_HSM_STATE_STARTED) { sbi_printf("%s: ERR: The hart is in invalid state [%u]\n", __func__, oldstate); - return SBI_EDENIED; + return SBI_EFAIL; } if (exitnow)