From bd873ab56a8fc0cb7d84a5b02afd51b6958864de Mon Sep 17 00:00:00 2001 From: Oza Pawandeep Date: Wed, 18 Nov 2026 13:55:47 -0800 Subject: [PATCH] lib: utils: mpxy: Fix RPMI service ID lookup mpxy_find_rpmi_srvid() incorrectly used the current service ID to control iteration through the service table. This could stop the search prematurely or read beyond the table. Bound the search using num_services so every registered service is checked without accessing entries past the end of the array. Fixes: c5a8b15e398a ("lib: utils/mpxy: Add RPMI client driver for MPXY") Reviewed-by: Rahul Pathak Reviewed-by: Anup Patel Signed-off-by: Oza Pawandeep Link: https://lore.kernel.org/r/20261118215549.2499040-7-pawandeep.oza@oss.qualcomm.com Signed-off-by: Anup Patel --- lib/utils/mpxy/fdt_mpxy_rpmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/utils/mpxy/fdt_mpxy_rpmi.c b/lib/utils/mpxy/fdt_mpxy_rpmi.c index 6b71803d..624831be 100644 --- a/lib/utils/mpxy/fdt_mpxy_rpmi.c +++ b/lib/utils/mpxy/fdt_mpxy_rpmi.c @@ -76,7 +76,7 @@ static const struct mpxy_rpmi_service_data *mpxy_find_rpmi_srvid(u32 message_id, const struct mpxy_rpmi_service_data *srv = data->service_data; int mid = 0; - for (mid = 0; srv[mid].id < data->num_services; mid++) { + for (mid = 0; mid < data->num_services; mid++) { if (srv[mid].id == (u8)message_id) return &srv[mid]; }