From b0c9df514bdb29a0c90c9868f4209f2ac7a6d567 Mon Sep 17 00:00:00 2001 From: Atish Patra Date: Thu, 28 Apr 2022 11:48:29 -0700 Subject: [PATCH] lib: sbi: Fix mhpmeventh access for rv32 in absence of sscofpmf MHPMEVENT3H-31H are defined in sscofpmf extension. Thus, they should be accessed only if sscofpmf is present. Signed-off-by: Atish Patra Reviewed-by: Anup Patel --- lib/sbi/riscv_asm.c | 4 ++++ lib/sbi/sbi_pmu.c | 8 ++++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/lib/sbi/riscv_asm.c b/lib/sbi/riscv_asm.c index 5eab1ed5..ddc4c139 100644 --- a/lib/sbi/riscv_asm.c +++ b/lib/sbi/riscv_asm.c @@ -139,6 +139,10 @@ unsigned long csr_read_num(int csr_num) switchcase_csr_read_4(CSR_MHPMCOUNTER4H, ret) switchcase_csr_read_8(CSR_MHPMCOUNTER8H, ret) switchcase_csr_read_16(CSR_MHPMCOUNTER16H, ret) + /** + * The CSR range MHPMEVENT[3-16]H are available only if sscofpmf + * extension is present. The caller must ensure that. + */ switchcase_csr_read(CSR_MHPMEVENT3H, ret) switchcase_csr_read_4(CSR_MHPMEVENT4H, ret) switchcase_csr_read_8(CSR_MHPMEVENT8H, ret) diff --git a/lib/sbi/sbi_pmu.c b/lib/sbi/sbi_pmu.c index 7ea0ca5e..f458c6d4 100644 --- a/lib/sbi/sbi_pmu.c +++ b/lib/sbi/sbi_pmu.c @@ -404,7 +404,9 @@ static int pmu_reset_hw_mhpmevent(int ctr_idx) return SBI_EFAIL; #if __riscv_xlen == 32 csr_write_num(CSR_MHPMEVENT3 + ctr_idx - 3, 0); - csr_write_num(CSR_MHPMEVENT3H + ctr_idx - 3, 0); + if (sbi_hart_has_feature(sbi_scratch_thishart_ptr(), + SBI_HART_HAS_SSCOFPMF)) + csr_write_num(CSR_MHPMEVENT3H + ctr_idx - 3, 0); #else csr_write_num(CSR_MHPMEVENT3 + ctr_idx - 3, 0); #endif @@ -483,7 +485,9 @@ static int pmu_update_hw_mhpmevent(struct sbi_pmu_hw_event *hw_evt, int ctr_idx, #if __riscv_xlen == 32 csr_write_num(CSR_MHPMEVENT3 + ctr_idx - 3, mhpmevent_val & 0xFFFFFFFF); - csr_write_num(CSR_MHPMEVENT3H + ctr_idx - 3, mhpmevent_val >> BITS_PER_LONG); + if (sbi_hart_has_feature(scratch, SBI_HART_HAS_SSCOFPMF)) + csr_write_num(CSR_MHPMEVENT3H + ctr_idx - 3, + mhpmevent_val >> BITS_PER_LONG); #else csr_write_num(CSR_MHPMEVENT3 + ctr_idx - 3, mhpmevent_val); #endif