diff --git a/include/sbi/sbi_pmu.h b/include/sbi/sbi_pmu.h index c0e25f5a..3fff4627 100644 --- a/include/sbi/sbi_pmu.h +++ b/include/sbi/sbi_pmu.h @@ -136,7 +136,7 @@ int sbi_pmu_add_hw_event_counter_map(u32 eidx_start, u32 eidx_end, u32 cmap); int sbi_pmu_add_raw_event_counter_map(uint64_t select, uint64_t select_mask, u32 cmap); -int sbi_pmu_ctr_fw_read(uint32_t cidx, uint64_t *cval); +int sbi_pmu_ctr_fw_read(unsigned long cidx, uint64_t *cval, bool high_bits); int sbi_pmu_ctr_stop(unsigned long cidx_base, unsigned long cidx_mask, unsigned long flag); diff --git a/lib/sbi/sbi_ecall_pmu.c b/lib/sbi/sbi_ecall_pmu.c index 868e8665..41bb1624 100644 --- a/lib/sbi/sbi_ecall_pmu.c +++ b/lib/sbi/sbi_ecall_pmu.c @@ -50,12 +50,12 @@ static int sbi_ecall_pmu_handler(unsigned long extid, unsigned long funcid, break; case SBI_EXT_PMU_COUNTER_FW_READ: - ret = sbi_pmu_ctr_fw_read(regs->a0, &temp); + ret = sbi_pmu_ctr_fw_read(regs->a0, &temp, false); out->value = temp; break; case SBI_EXT_PMU_COUNTER_FW_READ_HI: + ret = sbi_pmu_ctr_fw_read(regs->a0, &temp, true); #if __riscv_xlen == 32 - ret = sbi_pmu_ctr_fw_read(regs->a0, &temp); out->value = temp >> 32; #else out->value = 0; diff --git a/lib/sbi/sbi_pmu.c b/lib/sbi/sbi_pmu.c index 75038f91..ae00ad58 100644 --- a/lib/sbi/sbi_pmu.c +++ b/lib/sbi/sbi_pmu.c @@ -227,7 +227,7 @@ static bool pmu_ctr_idx_validate(unsigned long cbase, unsigned long cmask) return cmask && cbase + sbi_fls(cmask) < total_ctrs; } -int sbi_pmu_ctr_fw_read(uint32_t cidx, uint64_t *cval) +int sbi_pmu_ctr_fw_read(unsigned long cidx, uint64_t *cval, bool high_bits) { int event_idx_type; uint32_t event_code; @@ -236,6 +236,14 @@ int sbi_pmu_ctr_fw_read(uint32_t cidx, uint64_t *cval) if (unlikely(!phs)) return SBI_EINVAL; + if (cidx < num_hw_ctrs || cidx >= total_ctrs) + return SBI_EINVAL; + +#if __riscv_xlen > 32 + if (high_bits) + return 0; +#endif + event_idx_type = pmu_ctr_validate(phs, cidx, &event_code); if (event_idx_type != SBI_PMU_EVENT_TYPE_FW) return SBI_EINVAL;