From 7f1be8a624aca4805020588894d96c3617860c89 Mon Sep 17 00:00:00 2001 From: Jessica Clarke Date: Sun, 11 Jul 2021 03:28:19 +0100 Subject: [PATCH] fw_base: Don't mark fw_platform_init as both global and weak These are mutually exclusive. GNU as and LLVM both let later binding directives override earlier ones so this works as intended, but LLVM 12 turned this into a warning as there's no good reason to do such a thing and could be a potential bug. Thus, remove the redundant and incorrect .globl directive for fw_platform_init. Signed-off-by: Jessica Clarke Reviewed-by: Bin Meng Tested-by: Bin Meng Reviewed-by: Anup Patel --- firmware/fw_base.S | 1 - 1 file changed, 1 deletion(-) diff --git a/firmware/fw_base.S b/firmware/fw_base.S index 8e40562d..a1213e3b 100644 --- a/firmware/fw_base.S +++ b/firmware/fw_base.S @@ -558,7 +558,6 @@ _start_hang: .section .entry, "ax", %progbits .align 3 - .globl fw_platform_init .weak fw_platform_init fw_platform_init: add a0, a1, zero