From 7b087781c210b756f6c6ca8e66d43a6d3b02af0a Mon Sep 17 00:00:00 2001 From: Heinrich Schuchardt Date: Thu, 8 Dec 2022 02:14:21 +0100 Subject: [PATCH] lib: fix irqchip_plic_update_hartid_table After determining cpu_offset we have to check this value. Addresses-Coverity-ID: 1529706 ("Logically dead code") Signed-off-by: Heinrich Schuchardt Reviewed-by: Xiang W Reviewed-by: Atish Patra Reviewed-by: Anup Patel --- lib/utils/irqchip/fdt_irqchip_plic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/utils/irqchip/fdt_irqchip_plic.c b/lib/utils/irqchip/fdt_irqchip_plic.c index a6e185cf..fe08836a 100644 --- a/lib/utils/irqchip/fdt_irqchip_plic.c +++ b/lib/utils/irqchip/fdt_irqchip_plic.c @@ -86,7 +86,7 @@ static int irqchip_plic_update_hartid_table(void *fdt, int nodeoff, continue; cpu_offset = fdt_parent_offset(fdt, cpu_intc_offset); - if (cpu_intc_offset < 0) + if (cpu_offset < 0) continue; err = fdt_parse_hart_id(fdt, cpu_offset, &hartid);