From 548518e675d0ed387ff3ee2d9a2226a6e93090a4 Mon Sep 17 00:00:00 2001 From: "David E. Garcia Porras" Date: Mon, 27 Jul 2026 12:30:41 -0600 Subject: [PATCH] lib: sbi: dbtr: return SBI_ERR_INVALID_PARAM for invalid trigger configuration sbi_dbtr_install_trig() returns the generic SBI_ERR_FAILED when dbtr_trigger_valid() rejects a trigger configuration (dmode or M-mode bits set), where SBI v3.0 section 19.4 defines SBI_ERR_INVALID_PARAM for an invalid trigger configuration entry. Return SBI_ERR_INVALID_PARAM instead. Fixes: 97f234f15c96 ("lib: sbi: Introduce the SBI debug triggers extension support") Signed-off-by: David E. Garcia Porras Reviewed-by: Anup Patel Link: https://lore.kernel.org/r/20260727183041.258377-4-david.garcia@aheadcomputing.com Signed-off-by: Anup Patel --- lib/sbi/sbi_dbtr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/sbi/sbi_dbtr.c b/lib/sbi/sbi_dbtr.c index 712b0c66..60ac2742 100644 --- a/lib/sbi/sbi_dbtr.c +++ b/lib/sbi/sbi_dbtr.c @@ -648,7 +648,7 @@ int sbi_dbtr_install_trig(unsigned long smode, *out = _idx; sbi_hart_protection_unmap_range((unsigned long)shmem_base, trig_count * sizeof(*entry)); - return SBI_ERR_FAILED; + return SBI_ERR_INVALID_PARAM; } if ((recv->tdata2 && !tdata2_impl) ||