From 21caaa3f56c5b8297cda228a93e76bb66a1313c9 Mon Sep 17 00:00:00 2001 From: Zhang Runmin Date: Sun, 17 Dec 2023 21:48:36 +0800 Subject: [PATCH] fw_base.S: Fix comment errors When calling '_reset_regs', it'll reset all registers except some specific registers (ra, a0, a1, and a2). Both boot HART and non-boot HARTs will execute the '_start_warm' function. Therefore, when '_reset_regs' is called in '_start_warm', it will reset all registers except some specific registers (ra, a0, a1 and a2) for both boot HART and non-boot HARTs. Signed-off-by: Zhang Runmin Reviewed-by: Anup Patel --- firmware/fw_base.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/firmware/fw_base.S b/firmware/fw_base.S index f7763f4d..856bccdb 100644 --- a/firmware/fw_base.S +++ b/firmware/fw_base.S @@ -188,7 +188,7 @@ _relocate_done: /* At this point we are running from link address */ - /* Reset all registers for boot HART */ + /* Reset all registers except ra, a0, a1 and a2 for boot HART */ li ra, 0 call _reset_regs @@ -415,7 +415,7 @@ _wait_for_boot_hart: bne t0, t1, _wait_for_boot_hart _start_warm: - /* Reset all registers for non-boot HARTs */ + /* Reset all registers except ra, a0, a1 and a2 for non-boot HARTs */ li ra, 0 call _reset_regs