From 16fa280b6949463c506dc7f0c1030a208afecdbf Mon Sep 17 00:00:00 2001 From: Jakub Janeczko Date: Sat, 24 Oct 2026 21:57:31 +0200 Subject: [PATCH] lib: sbi_pmu: Fix race on pmu_ctr_write_hw On platforms where a bit of mcountinhibit cannot be set to 1, and when on rv32, pmu_ctr_write_hw() was given value whose lower bits were close to 2^32, the write could miss the lower bit overflow. Signed-off-by: Jakub Janeczko Reviewed-by: Anup Patel Link: https://lore.kernel.org/r/20261024195739.585621-1-kuba@ev1.pl Signed-off-by: Anup Patel --- lib/sbi/sbi_pmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/sbi/sbi_pmu.c b/lib/sbi/sbi_pmu.c index 653b8f69..6ad3509c 100644 --- a/lib/sbi/sbi_pmu.c +++ b/lib/sbi/sbi_pmu.c @@ -393,8 +393,8 @@ static void pmu_ctr_write_hw(uint32_t cidx, uint64_t ival) { #if __riscv_xlen == 32 csr_write_num(CSR_MCYCLE + cidx, 0); - csr_write_num(CSR_MCYCLE + cidx, ival & 0xFFFFFFFF); csr_write_num(CSR_MCYCLEH + cidx, ival >> BITS_PER_LONG); + csr_write_num(CSR_MCYCLE + cidx, ival & 0xFFFFFFFF); #else csr_write_num(CSR_MCYCLE + cidx, ival); #endif