From b628cfd6a0c1e8bf858b33a62d6a6fa16f4db640 Mon Sep 17 00:00:00 2001 From: Atish Patra Date: Mon, 8 Nov 2021 10:53:04 -0800 Subject: [PATCH] lib: sbi: Counter info width should be zero indexed The mhpm bits represent the number of bits available in mhpmcounter while counter width describes a zero indexed value. Fix the counter width calculation. Fixes: 13d40f21d588 ("lib: sbi: Add PMU support") Reviewed-by: Bin Meng Reviewed-by: Anup Patel Signed-off-by: Atish Patra --- lib/sbi/sbi_pmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/sbi/sbi_pmu.c b/lib/sbi/sbi_pmu.c index 1bb3e494..da8a37b1 100644 --- a/lib/sbi/sbi_pmu.c +++ b/lib/sbi/sbi_pmu.c @@ -649,7 +649,7 @@ int sbi_pmu_ctr_get_info(uint32_t cidx, unsigned long *ctr_info) if (cidx == 0 || cidx == 2) cinfo.width = 63; else - cinfo.width = sbi_hart_mhpm_bits(scratch); + cinfo.width = sbi_hart_mhpm_bits(scratch) - 1; } else { /* it's a firmware counter */ cinfo.type = SBI_PMU_CTR_TYPE_FW;