From 879ee6859cfb2d3241923af615f7f1e77aba32c5 Mon Sep 17 00:00:00 2001 From: Anup Patel Date: Sun, 12 Jan 2025 10:40:01 +0530 Subject: [PATCH] lib: utils: Drop notifications from MPXY RPMI mailbox client Currently, the common MPXY RPMI mailbox client does not support notifications so no need for dummy notifications support. Signed-off-by: Anup Patel Reviewed-by: Samuel Holland --- include/sbi_utils/mpxy/fdt_mpxy_rpmi_mbox.h | 1 - lib/utils/mpxy/fdt_mpxy_rpmi_clock.c | 1 - lib/utils/mpxy/fdt_mpxy_rpmi_mbox.c | 12 ------------ 3 files changed, 14 deletions(-) diff --git a/include/sbi_utils/mpxy/fdt_mpxy_rpmi_mbox.h b/include/sbi_utils/mpxy/fdt_mpxy_rpmi_mbox.h index df81a73d..373b077a 100644 --- a/include/sbi_utils/mpxy/fdt_mpxy_rpmi_mbox.h +++ b/include/sbi_utils/mpxy/fdt_mpxy_rpmi_mbox.h @@ -62,7 +62,6 @@ struct mpxy_rpmi_service_data { struct mpxy_rpmi_mbox_data { u32 servicegrp_id; u32 num_services; - u32 notifications_support; struct mpxy_rpmi_service_data *service_data; /** Transfer RPMI service group message */ diff --git a/lib/utils/mpxy/fdt_mpxy_rpmi_clock.c b/lib/utils/mpxy/fdt_mpxy_rpmi_clock.c index 4e36d4f5..7d2b4a20 100644 --- a/lib/utils/mpxy/fdt_mpxy_rpmi_clock.c +++ b/lib/utils/mpxy/fdt_mpxy_rpmi_clock.c @@ -72,7 +72,6 @@ static struct mpxy_rpmi_service_data clock_services[] = { static const struct mpxy_rpmi_mbox_data clock_data = { .servicegrp_id = RPMI_SRVGRP_CLOCK, .num_services = RPMI_CLOCK_SRV_MAX_COUNT, - .notifications_support = 1, .service_data = clock_services, }; diff --git a/lib/utils/mpxy/fdt_mpxy_rpmi_mbox.c b/lib/utils/mpxy/fdt_mpxy_rpmi_mbox.c index 6db750fb..cbcea4f2 100644 --- a/lib/utils/mpxy/fdt_mpxy_rpmi_mbox.c +++ b/lib/utils/mpxy/fdt_mpxy_rpmi_mbox.c @@ -213,13 +213,6 @@ static int mpxy_mbox_send_message_withoutresp(struct sbi_mpxy_channel *channel, NULL, 0, NULL); } -static int mpxy_mbox_get_notifications(struct sbi_mpxy_channel *channel, - void *eventsbuf, u32 bufsize, - unsigned long *events_len) -{ - return SBI_ENOTSUPP; -} - int mpxy_rpmi_mbox_init(const void *fdt, int nodeoff, const struct fdt_match *match) { int rc, len; @@ -277,11 +270,6 @@ int mpxy_rpmi_mbox_init(const void *fdt, int nodeoff, const struct fdt_match *ma mpxy_mbox_send_message_withresp; rmb->channel.send_message_without_response = mpxy_mbox_send_message_withoutresp; - /* Callback to get RPMI notifications */ - rmb->channel.get_notification_events = mpxy_mbox_get_notifications; - - /* No callback to switch events state data */ - rmb->channel.switch_eventsstate = NULL; /* RPMI Message Protocol ID */ rmb->channel.attrs.msg_proto_id = SBI_MPXY_MSGPROTO_RPMI_ID;