From 4825a3f87f8d3ee45b7f9b76ed62de7bd1f2dfa8 Mon Sep 17 00:00:00 2001 From: Jessica Clarke Date: Thu, 10 Jul 2025 00:28:39 +0100 Subject: [PATCH] include: sbi: Don't use #pragma when preprocessing device tree sources Since this persists in the preprocessed output (so that it can affect the subsequent compilation), it ends up in the input to dtc and is a syntax error, breaking the k210 build. Ideally we wouldn't add the -include flag to DTSCPPFLAGS in the first place as this header is wholly pointless there, but that's a more invasive build system change compared to just making this header safe to include there. Fixes: 86c01a73ff9d ("lib: sbi: Avoid GOT indirection for global symbol references") Signed-off-by: Jessica Clarke Reviewed-by: Samuel Holland Tested-by: Xiang W Reviewed-by: Xiang W Link: https://lore.kernel.org/r/20250709232840.37551-1-jrtc27@jrtc27.com Signed-off-by: Anup Patel --- include/sbi/sbi_visibility.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/sbi/sbi_visibility.h b/include/sbi/sbi_visibility.h index e9c401c5..f900c445 100644 --- a/include/sbi/sbi_visibility.h +++ b/include/sbi/sbi_visibility.h @@ -7,10 +7,12 @@ #ifndef __SBI_VISIBILITY_H__ #define __SBI_VISIBILITY_H__ +#ifndef __DTS__ /* * Declare all global objects with hidden visibility so access is PC-relative * instead of going through the GOT. */ #pragma GCC visibility push(hidden) +#endif #endif